Skip to content

Commit fbacece

Browse files
Update LaravelConfigTest.php
1 parent 8015d31 commit fbacece

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

Diff for: composer.json

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"require": {
3434
"php": "^7.4|^8.0|^8.1|^8.2",
3535
"ext-json": "*",
36+
"doctrine/dbal": "^3.8",
3637
"illuminate/support": "^8.49|^9.0|^10.0",
3738
"laravel/legacy-factories": "^1.0"
3839
},

Diff for: database/migrations/2021_07_08_091648_create_config_table.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function up(): void
1717
Schema::create($tableName, function (Blueprint $table) {
1818
$table->bigIncrements('id');
1919
$table->string('name')->unique();
20-
$table->enum('type', ['boolean', 'text'])->default('boolean');
20+
$table->string('type')->default('boolean');
2121
$table->string('val')->nullable();
2222
$table->text('description')->nullable();
2323
$table->timestamps();

Diff for: tests/LaravelConfigTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function it_create_a_new_config_parameter(): void
2626
{
2727
$factory = new ConfigFactory();
2828
$configItem = $factory->setName(Str::random(5))
29-
->setType('boolean')
29+
->setType(ConfigDataType::BOOLEAN)
3030
->setValue('1')
3131
->setDescription(Str::random(50))
3232
->get();
@@ -46,7 +46,7 @@ public function it_create_a_new_config_parameter_with_tag(): void
4646
{
4747
$factory = new ConfigFactory();
4848
$configItem = $factory->setName(Str::random(5))
49-
->setType('boolean')
49+
->setType(ConfigDataType::BOOLEAN)
5050
->setValue('1')
5151
->setTags(['system'])
5252
->setDescription(Str::random(50))
@@ -72,7 +72,7 @@ public function it_does_not_create_a_config_parameter_with_the_same_name(): void
7272

7373
$factory = new ConfigFactory();
7474
$configItem = $factory->setName($config->name)
75-
->setType('boolean')
75+
->setType(ConfigDataType::BOOLEAN)
7676
->setValue('1')
7777
->setDescription(Str::random(50))
7878
->get();
@@ -89,7 +89,7 @@ public function it_updates_existing_config_parameter(): void
8989
$this->assertDatabaseHas(config('laravel-config.table'), ['name' => $config->name, 'val' => $config->val]);
9090

9191
$factory = new ConfigFactory($config);
92-
$configItem = $factory->setType('boolean')
92+
$configItem = $factory->setType(ConfigDataType::BOOLEAN)
9393
->setValue('0')
9494
->setDescription('updated-description')
9595
->get();

0 commit comments

Comments
 (0)