Skip to content

Commit 353ef73

Browse files
committed
deps: remove problematic comment from v8-internal
GCC emits warnings because of the trailing backslashes. PR-URL: nodejs#58070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent e446217 commit 353ef73

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.3',
41+
'v8_embedder_string': '-node.4',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/include/v8-internal.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -423,19 +423,6 @@ constexpr size_t kMaxCppHeapPointers = 0;
423423
// which all subtypes of a given supertype use contiguous tags. This struct can
424424
// then be used to represent such a type range.
425425
//
426-
// As an example, consider the following type hierarchy:
427-
//
428-
// A F
429-
// / \
430-
// B E
431-
// / \
432-
// C D
433-
//
434-
// A potential type id assignment for range-based type checks is
435-
// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A
436-
// would check for the range [A, E], while the check for B would check range
437-
// [B, D], and for F it would simply check [F, F].
438-
//
439426
// In addition, there is an option for performance tweaks: if the size of the
440427
// type range corresponding to a supertype is a power of two and starts at a
441428
// power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize

0 commit comments

Comments
 (0)