Base.Result.all does not reverse

So we should re-reverse the list

Author: reynir

cli/lock.ml

@@ -211,6 +211,7 @@ let pull_pin_depends ~global_state pin_depends =
             | Error _ as e, _ | Ok _, (Error _ as e) -> e
             | Ok acc, Ok r -> Ok (r :: acc))
         ~init:(Ok [])
+      |> List.rev
     in
     OpamPackage.Name.Map.of_list (List.concat elms)
 
@@ -337,6 +338,7 @@ let make_repositories_locally_available repositories =
         | Error _ as e, _ | Ok _, (Error _ as e) -> e
         | Ok acc, Ok r -> Ok (r :: acc))
     ~init:(Ok [])
+  |> List.rev
 
 
 let opam_env_from_global_state global_state =

lib/duniverse.ml

@@ -257,6 +257,7 @@ let dev_repo_package_map_to_repos dev_repo_package_map =
           | Error _ as e, _ | Ok _, (Error _ as e) -> e
           | Ok acc, Ok r -> Ok (r :: acc))
       ~init:(Ok [])
+    |> List.rev
 
   in
   (* Detect the case where multiple different dev-repos are associated with the
@@ -312,6 +313,7 @@ let from_dependency_entries ~get_default_branch dependencies =
           | Ok acc, Ok r -> Ok (r :: acc))
       ~init:(Ok [])
       results
+    |> List.rev
   in
   let pkgs = List.filter_map ~f:Fun.id pkg_opts in
   let dev_repo_map = dev_repo_map_from_packages pkgs in
@@ -325,3 +327,4 @@ let resolve ~resolve_ref t =
         | Error _ as e, _ | Ok _, (Error _ as e) -> e
         | Ok acc, Ok r -> Ok (r :: acc))
     ~init:(Ok [])
+  |> List.rev

lib/pull.ml

@@ -49,6 +49,7 @@ let pull_source_dependencies ?trim_clone ~global_state ~duniverse_dir src_deps =
          | Error _ as e, _ | Ok _, (Error _ as e) -> e
          | Ok acc, Ok r -> Ok (r :: acc))
       ~init:(Ok [])
+    |> List.rev
   in
   let total = List.length src_deps in
   let pp_count = Pp.Styled.good Fmt.int in