fix: address telemetry inspector review

Author: tariknz

src/app/bridge/iracingSdk/iracingSdkBridge.ts

@@ -243,7 +243,6 @@ export async function publishIRacingSDKEvents(
 
   let shouldStop = false;
   let lastRunningState: boolean | undefined = undefined;
-  let latestTelemetry: Telemetry | null = null;
   let latestSession: Session | null = null;
 
   const telemetryCallbacks = new Set<(value: Telemetry) => void>();
@@ -261,12 +260,6 @@ export async function publishIRacingSDKEvents(
         'runningState',
         lastRunningState
       );
-    if (latestTelemetry && perfTelemetryDeliveryEnabled)
-      overlayManager.publishMessageToOverlay(
-        id,
-        'telemetryInspector:telemetry',
-        telemetryForRenderer(latestTelemetry)
-      );
     if (latestSession)
       overlayManager.publishMessageToOverlay(id, 'sessionData', latestSession);
   });
@@ -333,7 +326,6 @@ export async function publishIRacingSDKEvents(
         }
 
         if (telemetry) {
-          latestTelemetry = telemetry;
           perfMetrics.markStart('lifecycleTelemetry');
           lifecycle?._onTelemetry(telemetry);
           perfMetrics.markEnd('lifecycleTelemetry');
@@ -416,7 +408,6 @@ export async function publishIRacingSDKEvents(
         // opened during a disconnect don't get re-seeded with stale data, and
         // so the references don't sit in main-process memory indefinitely.
         // They get repopulated on the next successful waitForData tick.
-        latestTelemetry = null;
         latestSession = null;
         overlayManager.clearLatestSessionData?.();
         lifecycle?._onDisconnect();

src/frontend/components/Standings/Standings.stories.tsx

@@ -12,8 +12,6 @@ import {
 } from '@irdashies/storybook';
 import {
   DashboardProvider,
-  SessionProvider,
-  StoryTelemetryProvider,
   useLapTimesStoreUpdater,
   usePitLapStoreUpdater,
   useDrivingState,
@@ -25,7 +23,6 @@ import {
   useSessionDrivers,
   type P2PDisplayState,
 } from '@irdashies/context';
-import { generateMockDataFromPath } from '../../../app/bridge/iracingSdk/mock-data/generateMockData';
 import type {
   DashboardBridge,
   StandingsConfig,
@@ -1144,28 +1141,22 @@ export const HeaderOnlyAllVisible: Story = {
 
 export const CompactMode: Story = {
   decorators: [
+    TelemetryDecorator(),
     (Story) => (
-      <>
-        <SessionProvider bridge={generateMockDataFromPath()} />
-        <StoryTelemetryProvider bridge={generateMockDataFromPath()} />
-        <DashboardProvider bridge={createMockBridgeWithCompactMode()}>
-          <Story />
-        </DashboardProvider>
-      </>
+      <DashboardProvider bridge={createMockBridgeWithCompactMode()}>
+        <Story />
+      </DashboardProvider>
     ),
   ],
 };
 
 export const CompactUltraMode: Story = {
   decorators: [
+    TelemetryDecorator(),
     (Story) => (
-      <>
-        <SessionProvider bridge={generateMockDataFromPath()} />
-        <StoryTelemetryProvider bridge={generateMockDataFromPath()} />
-        <DashboardProvider bridge={createMockBridgeWithCompactUltraMode()}>
-          <Story />
-        </DashboardProvider>
-      </>
+      <DashboardProvider bridge={createMockBridgeWithCompactUltraMode()}>
+        <Story />
+      </DashboardProvider>
     ),
   ],
 };

src/frontend/components/TelemetryInspector/TelemetryInspector.stories.tsx

@@ -1,5 +1,5 @@
 import type { Meta, StoryObj } from '@storybook/react-vite';
-import { TelemetryDecorator } from '../../../../.storybook/telemetryDecorator';
+import { TelemetryDecorator } from '@irdashies/storybook';
 import { TelemetryInspector } from './TelemetryInspector';
 
 const InspectorStory = () => (

src/frontend/context/DashboardContext/DashboardContext.tsx

@@ -286,7 +286,7 @@ export const DashboardProvider: React.FC<{
 export const useDashboard = (): DashboardContextProps => {
   const context = useContext(DashboardContext);
   if (!context) {
-    throw new Error('useTelemetry requires a raw telemetry store');
+    throw new Error('useDashboard must be used within a DashboardProvider');
   }
   return context;
 };