Separation of concerns

[justinmakaila]

Hey hey,
I had some time this weekend, and was super interested in this project when I found it earlier this week. I'm a full-time React/react-native developer, and have grown frustrated with the available overlay solutions. I'm also an owner/admin over at FTR Events, an endurance racing league.

We've been playing with the pyirsdk for a couple years now to develop our proprietary "road-course caution" software. It's a CLI tool that an admin of a race session (typically a live-steward) can run with a given config file (.ini) to tailor the automated cautions. We've also explored building out custom overlays for our drivers to indicate certain things to them, and we've toyed with building local tools for them to run to enhance the "racedirector" experience.

A week or two ago, I put together a repo, for interacting with the iRacing /data API.

This weekend, I've pulled a lot of the "wrapper" code you had for the irsdk-node and put it in a sub-package of that repo (sup-package is not published yet).

I was wondering if you'd be interested with reviewing what I currently have, and if you'd be open to a feature PR to this library to use the package?

Wasn't sure how else to reach out, figured this was an appropriate avenue. Happy to keep discussions localized here or move to an email or discord thread.

Cheers,
Justin

[justinmakaila]

Pushed the SDK wrapper code here: https://github.com/racedirector/iracing-data-api/tree/feature/iracing-sdk/packages/sdk

[justinmakaila]

Service demonstrating usage is here: https://github.com/racedirector/iracing-data-api/tree/feature/iracing-sdk/services/telemetry-server

But to save you a click:

/* eslint-env node */
const { IRacingBridge } = require("@iracing-data/sdk");

const main = () => {
  const bridge = new IRacingBridge({
    fps: 1,
    retryConnection: true,
    retryIntervalSeconds: 5,
    maxRetryCount: 1,
  })
    // Register a telemetry event handler
    .onTelemetryEvent((telemetry) =>
      console.debug("Telemetry event:", telemetry)
    )
    // Register a session event handler
    .onSessionEvent((session) => console.debug("Session event:", session))
    .start();

  const shutdown = async () => {
    bridge.stop();
  };

  process.on("SIGTERM", shutdown);
  process.on("disconnect", shutdown);
};

main();

[tariknz]

Hey @justinmakaila - yeah nice I think event based approach is definitely a little better, I've speghettied it with the overlay manager. Happy to review a PR though and give it a test!

There's a couple of things on the irsdk-node package that need improving:

• I've currently got a PR open for irsdk-node here: fix build errors from electron bengsfort/irsdk-node#5. You'll notice there's a monkey patch code that runs on install hoping to get around it with this change. see: https://github.com/tariknz/irdashies/blob/main/patches/%40irsdk-node%2Bnative%2B4.0.1.patch
• Some types are also outdated, e.g. https://github.com/racedirector/iracing-data-api/blob/1b0187b90806e640a95aa22d83ae433cff964c18/packages/sdk/src/types/telemetry.ts#L4C1-L5C1 we should PR those back in.
• There's also also a bug I haven't really nailed down yet with irsdk-node with special characters, it doesn't render diacritics correctly right now.

[tariknz]

There's also a discord here if you want to jump on: https://discord.gg/E3KKB6W4