Skip to content

Commit 94f47da

Browse files
authored
fix Task object construction to have non-None {if,soft}_dependencies (#880)
This matches the type annotations, and matches an assumption in verify_task_dependencies.
1 parent 87d3550 commit 94f47da

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/taskgraph/generator.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ def load_tasks(self, parameters, kind_dependencies_tasks, write_artifacts):
100100
attributes=task_dict["attributes"],
101101
task=task_dict["task"],
102102
optimization=task_dict.get("optimization"),
103-
dependencies=task_dict.get("dependencies"),
104-
soft_dependencies=task_dict.get("soft-dependencies"),
105-
if_dependencies=task_dict.get("if-dependencies"),
103+
dependencies=task_dict.get("dependencies", {}),
104+
soft_dependencies=task_dict.get("soft-dependencies", []),
105+
if_dependencies=task_dict.get("if-dependencies", []),
106106
)
107107
for task_dict in transforms(trans_config, inputs)
108108
]

src/taskgraph/task.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ def from_json(cls, task_dict):
7575
attributes=task_dict["attributes"],
7676
task=task_dict["task"],
7777
optimization=task_dict["optimization"],
78-
dependencies=task_dict.get("dependencies"),
79-
soft_dependencies=task_dict.get("soft_dependencies"),
80-
if_dependencies=task_dict.get("if_dependencies"),
78+
dependencies=task_dict.get("dependencies", {}),
79+
soft_dependencies=task_dict.get("soft_dependencies", []),
80+
if_dependencies=task_dict.get("if_dependencies", []),
8181
)
8282
if "task_id" in task_dict:
8383
rv.task_id = task_dict["task_id"]

0 commit comments

Comments
 (0)