feat: improvements

Author: tatupesonen

.github/workflows/lint.yml

@@ -39,6 +39,9 @@ jobs:
       - name: Lint Frontend
         run: npm run lint
 
+      - name: TypeScript Check
+        run: npx tsc --noEmit
+
       # - name: Commit Changes
       #   uses: stefanzweifel/git-auto-commit-action@v7
       #   with:

app/Concerns/WorkshopModBehavior.php

@@ -32,6 +32,9 @@ public function modSections(): array
         ];
     }
 
+    /**
+     * @param  array<string, mixed>  $validated
+     */
     public function syncPresetMods(ModPreset $preset, array $validated): void
     {
         $preset->mods()->sync($validated['mod_ids'] ?? []);

app/Console/Commands/GenerateGameTypesCommand.php

@@ -167,6 +167,8 @@ private function extractFieldsBySource(array $schema): array
 
     /**
      * Resolve the TypeScript type for a schema field.
+     *
+     * @param  array<string, mixed>  $field
      */
     private function resolveFieldTsType(array $field): string
     {

app/Contracts/GameHandler.php

@@ -127,11 +127,15 @@ public function getServerLogPath(Server $server): string;
      * The optional $server parameter is provided during updates so that
      * unique rules can ignore the current server (e.g., query_port uniqueness).
      * On store, $server is null.
+     *
+     * @return array<string, mixed>
      */
     public function serverValidationRules(?Server $server = null): array;
 
     /**
      * Validation rules for game-specific settings (difficulty, network, reforger settings, etc.)
+     *
+     * @return array<string, mixed>
      */
     public function settingsValidationRules(): array;
 
@@ -185,6 +189,8 @@ public function createRelatedSettings(Server $server): void;
     /**
      * Update game-specific related settings from validated request data.
      * Called from ServerController::update().
+     *
+     * @param  array<string, mixed>  $validated
      */
     public function updateRelatedSettings(Server $server, array $validated): void;
 
@@ -203,6 +209,8 @@ public function modSections(): array;
     /**
      * Sync a preset's mods from validated request data.
      * Each handler knows which relationships to sync.
+     *
+     * @param  array<string, mixed>  $validated
      */
     public function syncPresetMods(ModPreset $preset, array $validated): void;
 

app/Contracts/SupportsRegisteredMods.php

@@ -32,6 +32,8 @@ public function registeredModPivotTable(): string;
 
     /**
      * Create a new registered mod from validated request data.
+     *
+     * @param  array<string, mixed>  $data
      */
     public function storeRegisteredMod(array $data): Model;
 

app/GameHandlers/AbstractGameHandler.php

@@ -3,9 +3,11 @@
 namespace App\GameHandlers;
 
 use App\Contracts\GameHandler;
+use App\Contracts\HasQueryPort;
 use App\Models\ModPreset;
 use App\Models\Server;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Validation\Rule;
 
 abstract class AbstractGameHandler implements GameHandler
 {
@@ -65,11 +67,27 @@ final public function settingsRelationName(): ?string
     // Default Implementations (override as needed)
     // ---------------------------------------------------------------
 
+    /**
+     * @return array<string, mixed>
+     */
     public function serverValidationRules(?Server $server = null): array
     {
-        return [];
+        $rules = [];
+
+        if ($this instanceof HasQueryPort) {
+            $rules['query_port'] = [
+                'required', 'integer', 'min:1', 'max:65535',
+                Rule::unique('servers', 'query_port')->when($server, fn ($rule) => $rule->ignore($server->id)),
+                Rule::unique('servers', 'port')->when($server, fn ($rule) => $rule->ignore($server->id)),
+            ];
+        }
+
+        return $rules;
     }
 
+    /**
+     * @return array<string, mixed>
+     */
     public function settingsValidationRules(): array
     {
         return [];
@@ -89,6 +107,9 @@ public function createRelatedSettings(Server $server): void
         $this->settingsModelClass::query()->create(['server_id' => $server->id]);
     }
 
+    /**
+     * @param  array<string, mixed>  $validated
+     */
     public function updateRelatedSettings(Server $server, array $validated): void
     {
         if ($this->settingsRelationName === null || $this->settingsModelClass === null) {
@@ -115,6 +136,9 @@ public function modSections(): array
         return [];
     }
 
+    /**
+     * @param  array<string, mixed>  $validated
+     */
     public function syncPresetMods(ModPreset $preset, array $validated): void
     {
         // No-op for handlers without mod support.

app/GameHandlers/Arma3Handler.php

@@ -16,7 +16,6 @@
 use App\Models\Server;
 use App\Services\Renderer\TwigConfigRenderer;
 use Illuminate\Support\Facades\Log;
-use Illuminate\Validation\Rule;
 
 final class Arma3Handler extends AbstractGameHandler implements DetectsServerState, HasQueryPort, ManagesModAssets, SteamGameHandler, SupportsBackups, SupportsHeadlessClients, SupportsMissions, SupportsWorkshopMods
 {
@@ -476,19 +475,21 @@ public function settingsSchema(): array
 
     // --- Validation ---
 
+    /**
+     * @return array<string, mixed>
+     */
     public function serverValidationRules(?Server $server = null): array
     {
         return [
-            'query_port' => [
-                'required', 'integer', 'min:1', 'max:65535',
-                Rule::unique('servers', 'query_port')->when($server, fn ($rule) => $rule->ignore($server->id)),
-                Rule::unique('servers', 'port')->when($server, fn ($rule) => $rule->ignore($server->id)),
-            ],
+            ...parent::serverValidationRules($server),
             'password' => ['nullable', 'string', 'max:255'],
             'additional_params' => ['nullable', 'string', 'max:1000'],
         ];
     }
 
+    /**
+     * @return array<string, mixed>
+     */
     public function settingsValidationRules(): array
     {
         return [

app/GameHandlers/FactorioHandler.php

@@ -284,19 +284,21 @@ public function settingsSchema(): array
 
     // --- Validation ---
 
+    /**
+     * @return array<string, mixed>
+     */
     public function serverValidationRules(?Server $server = null): array
     {
         return [
-            'query_port' => [
-                'required', 'integer', 'min:1', 'max:65535',
-                \Illuminate\Validation\Rule::unique('servers', 'query_port')->when($server, fn ($rule) => $rule->ignore($server->id)),
-                \Illuminate\Validation\Rule::unique('servers', 'port')->when($server, fn ($rule) => $rule->ignore($server->id)),
-            ],
+            ...parent::serverValidationRules($server),
             'password' => ['nullable', 'string', 'max:255'],
             'additional_params' => ['nullable', 'string', 'max:1000'],
         ];
     }
 
+    /**
+     * @return array<string, mixed>
+     */
     public function settingsValidationRules(): array
     {
         $scaleRule = 'in:none,very-low,low,normal,high,very-high';

app/GameHandlers/ProjectZomboidHandler.php

@@ -168,6 +168,9 @@ public function settingsSchema(): array
 
     // --- Validation ---
 
+    /**
+     * @return array<string, mixed>
+     */
     public function serverValidationRules(?Server $server = null): array
     {
         return [
@@ -176,6 +179,9 @@ public function serverValidationRules(?Server $server = null): array
         ];
     }
 
+    /**
+     * @return array<string, mixed>
+     */
     public function settingsValidationRules(): array
     {
         return [

app/GameHandlers/ReforgerHandler.php

@@ -205,6 +205,9 @@ public function settingsSchema(): array
 
     // --- Validation ---
 
+    /**
+     * @return array<string, mixed>
+     */
     public function settingsValidationRules(): array
     {
         return [
@@ -231,6 +234,9 @@ public function modSections(): array
         ];
     }
 
+    /**
+     * @param  array<string, mixed>  $validated
+     */
     public function syncPresetMods(ModPreset $preset, array $validated): void
     {
         $preset->reforgerMods()->sync($validated['reforger_mod_ids'] ?? []);
@@ -258,6 +264,9 @@ public function registeredModPivotTable(): string
         return 'mod_preset_reforger_mod';
     }
 
+    /**
+     * @param  array<string, mixed>  $data
+     */
     public function storeRegisteredMod(array $data): Model
     {
         return ReforgerMod::query()->create($data);