Ensure that (internal) files are closed in {save,load}ConfigFile

The {save,load}ConfigFile methods accept either a file name or a file object
as their argument. If a name is passed, a file object is internally created
and opened, but it is not closed. This may cause trouble. Make sure the
file is closed if it was internally created.
Note that, in order not to maintain backwards compatibility, the file
won't be closed if it was passed already as a file object (the
responsibility for closing lies in the opener)

Author: Carlos Pascual

lib/taurus/qt/qtcore/configuration/configuration.py

@@ -444,11 +444,13 @@ def saveConfigFile(self, ofile=None):
             )
             if not ofile:
                 return
-        if isinstance(ofile, string_types):
-            ofile = open(ofile, 'wb')
-        configdict = self.createConfig(allowUnpickable=False)
         self.info("Saving current settings in '%s'" % ofile.name)
-        pickle.dump(configdict, ofile)
+        configdict = self.createConfig(allowUnpickable=False)
+        if isinstance(ofile, string_types):
+            with open(ofile, 'wb') as ofile:
+                pickle.dump(configdict, ofile)
+        else:
+            pickle.dump(configdict, ofile)
         return ofile.name
 
     def loadConfigFile(self, ifile=None):
@@ -466,8 +468,9 @@ def loadConfigFile(self, ifile=None):
             if not ifile:
                 return
         if isinstance(ifile, string_types):
-            ifile = open(ifile, 'rb')
-
-        configdict = pickle.load(ifile)
+            with open(ifile, 'rb') as ifile:
+                configdict = pickle.load(ifile)
+        else:
+            configdict = pickle.load(ifile)
         self.applyConfig(configdict)
         return ifile.name