Double checking other cards that don't have an associated product

[axxroytovu]

It does seem like a lot of foils are listed in the full query so maybe it's a bug in the script...

Originally posted by @kodawah in #333 (comment)

[axxroytovu]

@kodawah any chance you can export those search results as a checklist instead of having the search through BAN?

[kodawah]

sure, here is today's results (so it won't reflect #333 changes)
list of uuids.csv
(using scryfall uuids)

[taw]

Do you need me to do anything to support this issue?

[axxroytovu]

Don't think so. Just reminding myself so I don't forget to do this eventually.

[taw]

@axxroytovu @kodawah Do you still want this issue open?

[kodawah]

@taw I mean I'd like the issue fixed 😛

I believe it's still happening https://www.mtgban.com/search?q=is%3Aproductless+date%3C2024-12-31+-is%3Apromo things like go-shintai (thick) are not pulled by the script (because etched?) but i don't know if it's a representation problem (we don't set etched, everything is foil) or if the script skips certain cards for some reason

[kodawah]

updated query https://www.mtgban.com/search?q=is%3aproductless%20date%3c2025-07-28%20-s%3aJ25%2cUNK%2cPCEL%2cFBB%2cSUM%2cMGB%20-t%3abasic%20-is%3ainstore%2coversize%2cjpn%2cschinesealtart%2cconvention%2cpromo%20-s%3aRIN%2cREN%20-s%3aMB2&p=2&sort=&reverse=false

(MB2 is also affected but report in another bug)

[kodawah]

note: the token and etched problem is definitely a mtgjson representation problem, but the missing foils is something deeper

[kodawah]

taw/magic-preconstructed-decks#186 fixes the thick cards

[taw]

@kodawah What's still left of this issue?

[kodawah]

there are a few macrocategories

• a few sld bonus
  • some cards might need extra representation, Products - question: how to map SLD bonus card that are delivered based on a purchase threshold mtgjson/mtg-sealed-content#310
  • some cards need new boosters (ie lands or slivers)
• there are a few missing lands from various sets, foil in particular https://www.mtgban.com/search?q=is%3Aproductless+date%3C2025+-is%3Apromo%2Csldbonus%2Cwizardsplaynetwork+t%3Aland+-e%3ASLD
  • SLD seems particularly problematic since we don't have etched field available, maybe we should give up and export that
• the various MKM misprints (ending with †) are not mapped to any product
• several foil printings of commander cards found in the set boosters https://www.mtgban.com/search?q=is%3Aproductless+date%3C2025+-is%3Apromo%2Csldbonus%2Cwizardsplaynetwork%2Cevent+-t%3Abasic+-cne%3A%E2%80%A0+s%3ALCC%2CLTC%2CWOC%2CDMC%2CNCC
• the modern horizon sets are all messed up, but i fear it's due to my change on the etched filtering, if we could fix that we would have fewer cards to deal with (same for STA)
• tokens, in particular the ones from SLD (but i think that's on mtgjson side @ZeldaZach)
• etched cards mapping is spotty at best