Failed links in sealed product data

[taw]

Warnings from automated test:

Product Born of the Gods Prerelease Kit Destined To Conquer contains unknown pack bng-prerelease-conquer
Product Born of the Gods Prerelease Kit Destined To Dominate contains unknown pack bng-prerelease-dominate
Product Born of the Gods Prerelease Kit Destined To Lead contains unknown pack bng-prerelease-lead
Product Born of the Gods Prerelease Kit Destined To Outwit contains unknown pack bng-prerelease-outwit
Product Born of the Gods Prerelease Kit Destined To Thrive contains unknown pack bng-prerelease-thrive
Product Aetherdrift Collector Booster Box contains unknown product dft Aetherdrift Box Topper Booster
Product Aetherdrift Collector Booster Sample Pack contains unknown pack dft-collector-sample
Product Duskmourn House of Horror Nightmare Bundle Booster contains unknown pack dsk-nightmare
Product Lorwyn Eclipsed Bundle contains unknown pack ecl-bundle-promo
Product Lorwyn Eclipsed Prerelease Pack contains unknown pack ecl-prerelease
Product Edge of Eternities Bundle contains unknown pack eoe-bundle-promo
Product Edge of Eternities Collector Booster Sample Pack contains unknown pack eoe-collector-sample
Product Edge of Eternities Prerelease Pack contains unknown pack eoe-prerelease
Product Final Fantasy Chocobo Bundle contains unknown pack fin-chocobo-scene-bundle
Product Portal Second Age Gift Box contains unknown product p02 Portal Second Age Demo Game Booster
Product Ravnica Allegiance Collector Booster Pack contains unknown pack rna-collector
Product Secrets of Strixhaven 60-Card Theme Deck Display contains unknown product sos Secrets of Strixhaven 60-Card Theme Deck Set of 2
Product Secrets of Strixhaven Bundle contains unknown pack sos-bundle-promo
Product Secrets of Strixhaven Codex Bundle contains unknown pack sos-codex-bundle
Product Secrets of Strixhaven Prerelease Pack Lorehold contains unknown pack sos-lorehold-prerelease
Product Secrets of Strixhaven Prerelease Pack Prismari contains unknown pack sos-prismari-prerelease
Product Secrets of Strixhaven Prerelease Pack Quandrix contains unknown pack sos-quandrix-prerelease
Product Secrets of Strixhaven Prerelease Pack Silverquill contains unknown pack sos-silverquill-prerelease
Product Secrets of Strixhaven Prerelease Pack Witherbloom contains unknown pack sos-witherbloom-prerelease
Product Marvels Spider Man Gift Bundle contains unknown pack spm-bundle-promo
Product Marvels Spider Man Prerelease Pack contains unknown pack spm-prerelease
Product Tarkir Dragonstorm Collector Booster Sample Pack contains unknown pack tdm-collector-sample
Product Teenage Mutant Ninja Turtles Bundle contains unknown pack tmt-bundle-promo
Product Time Spiral Tournament Pack contains unknown pack tsp-tournament

[taw]

Profit and Power is because recent PR broke it, it will self fix once it's fixed:

Skipping deck Fate Reforged - Power due to errors:
* Number 186 requested for Swamp but no such card found. Available numbers: 180, 181
Skipping deck Fate Reforged - Power and Profit due to errors:
* Number 186 requested for Swamp but no such card found. Available numbers: 180, 181
Skipping deck Fate Reforged - Profit due to errors:
* Number 186 requested for Swamp but no such card found. Available numbers: 180, 181

Some of unknown cards are just DFC card numbering issues. I'll adjust the script to be aware of that. DFC issues fixed.

There's some minor issue with collector number capitalization that I'll probably need to fix on my side as well. Capitalization issue fixed.

I think all 41 issues are on data side.

[kodawah]

Product Secret Lair Drop Crocodile Jacksons Monstrous Menagerie Etched contains foil card sld 590 Lurking Crocodile, but it's only available nonfoil

this one is on your side because you don't have a way to specify etched cards

i've just sent a fix for the other card examples (thanks for compiling the list)

[taw]

OK, cleaned up all card and foiling stuff by now, now we just have:

• 18x unknown pack
• 2x unknown deck
• 2x unknown product

Decks and products should be easy enough to fix. Packs, we'll probably never get it 100% done.

[taw]

Updated with fresh error list.

[taw]

I added all missing decks except "8ed Sampler Booster" @kodawah @axxroytovu any idea what's that?

[kodawah]

I added all missing decks except "8ed Sampler Booster" @kodawah @axxroytovu any idea what's that?

from https://www.magiclibrarities.net/1339-rarities-mtg-demo-game-boosters-and-samplers-english-cards-index.html

Contents: 10 fixed cards (5 Basic Lands and 5 Commons).
1 Small Elvish Champion Poster with MTG Advertising on the back.

Aven Flock C
Remove Soul C
Gravedigger C
Volcanic Hammer C
Craw Wurm C
Plains 333/350 C
Island 336/350 C
Swamp 341/350 C
Mountain 346/350 C
Forest 347/350 C

[taw]

OK, fixed 8ED Sampler Deck, so all cards and decks are now done (once it makes its way through the system).

It's now just 26x unknown pack, and 3x unknown product. Is keeping this issue open valuable?

@kodawah @axxroytovu

[kodawah]

i was thinking... don't we need boosters for prerelease card for each main set...? it'd be easier to model than whatever we could do in mtgjson

[taw]

If it's randomized, it's better to handle it as a booster.

[kodawah]

If it's randomized, it's better to handle it as a booster.

yeah and i think it's the usual rarity distribution... we'd need something to automatically generate queries from e:P{set} promo:prerelease with a couple of exceptions (LTR comes to mind) between KTK and Avatar.

[taw]

Do you want to PR just one and give me the list, and I can regexp or claude the rest?

[axxroytovu]

I previously built the prerelease packs to be easy to copy paste. Any set that doesn't have seeded boosters or extra promos can use the same content as data/boosters/aer-prerelease.yaml

[taw]

These are sets for which e:p{set} promo:prerelease exists, but there's not {set}-prerelease* booster, with count (all old sets with 1 promo don't really need a booster right?):

• 1: p5dn pala papc parb pavr pbok pchk pcon pcsp pdis pdst peve pexo pfut pgpt pinv pjud plgn plrw pm10 pm11 pm12 pm13 pm14 pmh1 pmmq pmor pmrd pnem pnph pody pons ppcy pplc ppls prav proe pscg pshm psok psom psth ptmp ptsp puds pusg pwwk pzen
• 1 DFC: pdka pisd
• 2 different cards: pdgm pmbs
• 2 variants: pptk pulg
• 3: ptor (some misprints of Laquatus's Champion?)
• 5: pbng pjou pm15 pths
• 22: pbbd
• 30: pfrf
• 40: pktk prna
• 45: pgrn pori
• 54: pogw
• 68: prix pthb
• 73: pspm
• 80: peoe pmh2
• 83: ptdm
• 86: psoi
• 88: ptla
• 106: pstx

Also these have have e:{set} promo:prerelease:

• cmr dbl ltr mkm moc

Which ones of them should I mass generate based on aer-prerelease.yaml?

[kodawah]

Which ones of them should I mass generate based on aer-prerelease.yaml?

i believe all the ones after KTK, as previously the cards were small set (or tied to a color)

[taw]

OK, based on following criteria:

• release date >= KTK
• more than 1 result from e:p{set} is:mainfront promo:prerelease
• no booster like {set}-prerelease*

I generated the following:

cp aer-prerelease.yaml tla-prerelease.yaml
cp aer-prerelease.yaml ori-prerelease.yaml
cp aer-prerelease.yaml rna-prerelease.yaml
cp aer-prerelease.yaml ktk-prerelease.yaml
cp aer-prerelease.yaml stx-prerelease.yaml
cp aer-prerelease.yaml mh2-prerelease.yaml
cp aer-prerelease.yaml eoe-prerelease.yaml
cp aer-prerelease.yaml rix-prerelease.yaml
cp aer-prerelease.yaml spm-prerelease.yaml
cp aer-prerelease.yaml frf-prerelease.yaml
cp aer-prerelease.yaml tdm-prerelease.yaml
cp aer-prerelease.yaml thb-prerelease.yaml
cp aer-prerelease.yaml soi-prerelease.yaml
cp aer-prerelease.yaml grn-prerelease.yaml
cp aer-prerelease.yaml ogw-prerelease.yaml
cp aer-prerelease.yaml bbd-prerelease.yaml

Pure regexp, no AI.

I'll push it all in the next build.

Anyway, let me know if any of these are incorrect, or anything else needs adding.