Merge pull request #221 from jarjee/fix_correct-hipblas-build

tazz4843 · web-flow · commit 83428a939a77 · 2025-06-07T23:24:23.000-07:00
fix: Correct broken hipblas build
diff --git a/sys/build.rs b/sys/build.rs
@@ -180,7 +180,7 @@ fn main() {
     }
 
     if cfg!(feature = "hipblas") {
-        config.define("GGML_HIPBLAS", "ON");
+        config.define("GGML_HIP", "ON");
         config.define("CMAKE_C_COMPILER", "hipcc");
         config.define("CMAKE_CXX_COMPILER", "hipcc");
         println!("cargo:rerun-if-env-changed=AMDGPU_TARGETS");
@@ -274,6 +274,10 @@ fn main() {
         println!("cargo:rustc-link-lib=static=ggml-vulkan");
     }
 
+    if cfg!(feature = "hipblas") {
+        println!("cargo:rustc-link-lib=static=ggml-hip");
+    }
+
     if cfg!(feature = "metal") {
         println!("cargo:rustc-link-lib=static=ggml-metal");
     }

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ fn main() {`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`if cfg!(feature = "hipblas") {`
`183`		`- config.define("GGML_HIPBLAS", "ON");`
	`183`	`+ config.define("GGML_HIP", "ON");`
`184`	`184`	`config.define("CMAKE_C_COMPILER", "hipcc");`
`185`	`185`	`config.define("CMAKE_CXX_COMPILER", "hipcc");`
`186`	`186`	`println!("cargo:rerun-if-env-changed=AMDGPU_TARGETS");`
`@@ -274,6 +274,10 @@ fn main() {`
`274`	`274`	`println!("cargo:rustc-link-lib=static=ggml-vulkan");`
`275`	`275`	`}`
`276`	`276`
	`277`	`+ if cfg!(feature = "hipblas") {`
	`278`	`+ println!("cargo:rustc-link-lib=static=ggml-hip");`
	`279`	`+ }`
	`280`	`+`
`277`	`281`	`if cfg!(feature = "metal") {`
`278`	`282`	`println!("cargo:rustc-link-lib=static=ggml-metal");`
`279`	`283`	`}`