Normative: consuming helpers close receiver on argument validation failure (#3467)

Author: bakkot

spec.html

@@ -47391,8 +47391,11 @@ <h1>Iterator.prototype.every ( _predicate_ )</h1>
         <emu-alg>
           1. Let _O_ be the *this* value.
           1. If _O_ is not an Object, throw a *TypeError* exception.
-          1. If IsCallable(_predicate_) is *false*, throw a *TypeError* exception.
-          1. Let _iterated_ be ? GetIteratorDirect(_O_).
+          1. Let _iterated_ be the Iterator Record { [[Iterator]]: _O_, [[NextMethod]]: *undefined*, [[Done]]: *false* }.
+          1. If IsCallable(_predicate_) is *false*, then
+            1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
+            1. Return ? IteratorClose(_iterated_, _error_).
+          1. Set _iterated_ to ? GetIteratorDirect(_O_).
           1. Let _counter_ be 0.
           1. Repeat,
             1. Let _value_ be ? IteratorStepValue(_iterated_).
@@ -47438,8 +47441,11 @@ <h1>Iterator.prototype.find ( _predicate_ )</h1>
         <emu-alg>
           1. Let _O_ be the *this* value.
           1. If _O_ is not an Object, throw a *TypeError* exception.
-          1. If IsCallable(_predicate_) is *false*, throw a *TypeError* exception.
-          1. Let _iterated_ be ? GetIteratorDirect(_O_).
+          1. Let _iterated_ be the Iterator Record { [[Iterator]]: _O_, [[NextMethod]]: *undefined*, [[Done]]: *false* }.
+          1. If IsCallable(_predicate_) is *false*, then
+            1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
+            1. Return ? IteratorClose(_iterated_, _error_).
+          1. Set _iterated_ to ? GetIteratorDirect(_O_).
           1. Let _counter_ be 0.
           1. Repeat,
             1. Let _value_ be ? IteratorStepValue(_iterated_).
@@ -47496,8 +47502,11 @@ <h1>Iterator.prototype.forEach ( _procedure_ )</h1>
         <emu-alg>
           1. Let _O_ be the *this* value.
           1. If _O_ is not an Object, throw a *TypeError* exception.
-          1. If IsCallable(_procedure_) is *false*, throw a *TypeError* exception.
-          1. Let _iterated_ be ? GetIteratorDirect(_O_).
+          1. Let _iterated_ be the Iterator Record { [[Iterator]]: _O_, [[NextMethod]]: *undefined*, [[Done]]: *false* }.
+          1. If IsCallable(_procedure_) is *false*, then
+            1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
+            1. Return ? IteratorClose(_iterated_, _error_).
+          1. Set _iterated_ to ? GetIteratorDirect(_O_).
           1. Let _counter_ be 0.
           1. Repeat,
             1. Let _value_ be ? IteratorStepValue(_iterated_).
@@ -47541,8 +47550,11 @@ <h1>Iterator.prototype.reduce ( _reducer_ [ , _initialValue_ ] )</h1>
         <emu-alg>
           1. Let _O_ be the *this* value.
           1. If _O_ is not an Object, throw a *TypeError* exception.
-          1. If IsCallable(_reducer_) is *false*, throw a *TypeError* exception.
-          1. Let _iterated_ be ? GetIteratorDirect(_O_).
+          1. Let _iterated_ be the Iterator Record { [[Iterator]]: _O_, [[NextMethod]]: *undefined*, [[Done]]: *false* }.
+          1. If IsCallable(_reducer_) is *false*, then
+            1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
+            1. Return ? IteratorClose(_iterated_, _error_).
+          1. Set _iterated_ to ? GetIteratorDirect(_O_).
           1. If _initialValue_ is not present, then
             1. Let _accumulator_ be ? IteratorStepValue(_iterated_).
             1. If _accumulator_ is ~done~, throw a *TypeError* exception.
@@ -47566,8 +47578,11 @@ <h1>Iterator.prototype.some ( _predicate_ )</h1>
         <emu-alg>
           1. Let _O_ be the *this* value.
           1. If _O_ is not an Object, throw a *TypeError* exception.
-          1. If IsCallable(_predicate_) is *false*, throw a *TypeError* exception.
-          1. Let _iterated_ be ? GetIteratorDirect(_O_).
+          1. Let _iterated_ be the Iterator Record { [[Iterator]]: _O_, [[NextMethod]]: *undefined*, [[Done]]: *false* }.
+          1. If IsCallable(_predicate_) is *false*, then
+            1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
+            1. Return ? IteratorClose(_iterated_, _error_).
+          1. Set _iterated_ to ? GetIteratorDirect(_O_).
           1. Let _counter_ be 0.
           1. Repeat,
             1. Let _value_ be ? IteratorStepValue(_iterated_).