tweak header name regex

Author: bakkot

src/lint/collect-header-diagnostics.ts

@@ -44,19 +44,16 @@ export function collectHeaderDiagnostics(
       // [[GetOwnProperty]]
       /^\[\[[A-Z][A-Za-z0-9]*\]\]\s*$/,
 
-      // _NativeError_
-      /^_[A-Z][A-Za-z0-9]*_\s*$/,
+      // ForIn/OfHeadEvaluation
+      /^[A-Za-z][A-Za-z0-9/]*\s*$/,
 
       // CreateForInIterator
       // Object.fromEntries
-      // ForIn/OfHeadEvaluation
+      // _NativeError_ [ @@whatever ]
       // Array.prototype [ @@iterator ]
-      // Object.prototype.__defineGetter__
-      /^[A-Za-z][A-Za-z0-9/]*(\.[A-Za-z][A-Za-z0-9]*)*(\.__[a-z][A-Za-z0-9]*__| \[ @@[a-z][a-zA-Z]+ \])?\s*$/,
-
       // %ForInIteratorPrototype%.next
-      // %TypedArray%.prototype [ @@iterator ]
-      /^%[A-Z][A-Za-z0-9]*%(\.[A-Za-z][A-Za-z0-9]*)*( \[ @@[a-z][a-zA-Z]+ \])?\s*$/,
+      // Object.prototype.__defineGetter__
+      /^([%_]?)[A-Za-z][A-Za-z0-9/]*\1(\.[A-Za-z][A-Za-z0-9]*|\.__[a-z][A-Za-z0-9]*__| \[ @@[a-z][a-zA-Z]+ \])*\s*$/,
     ].some(r => r.test(name));
 
     if (!nameMatches) {

test/lint.js

@@ -364,6 +364,9 @@ describe('linting whole program', () => {
           <emu-clause id="i9">
             <h1>Object.prototype.__defineGetter__ ( )</h1>
           </emu-clause>
+          <emu-clause id="i10">
+            <h1>_NativeError_ [ @@baz ] ( )</h1>
+          </emu-clause>
       `);
     });