Skip to content

Consider removing/renaming ngDevMode const declaration from the polyfill #174

Open
@Maximaximum

Description

Currenty, the polyfill depends on the existence of the ngDevMode variable in several places to decide whether it should throw useful error messages. This is obviously a copy-paste artifact from the Angular signals codebase.

Looks like the variable should be renamed to something framework-agnostic, like signal-polyfill-debug, and its usage should be documented in the README. Otherwise, any mentions of ngDevMode could be removed altogether, and the debug messages could just always be printed.

I'd be willing to make a PR for that if needed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions