Skip to content

Commit 8296db8

Browse files
rmahdavtest262-merge-bot
authored andcommitted
[explicit-resource-management] Return undefined from dispose builtin
This CL fixes the bug of returning true in dispose method of DisposableStack. Bug: 385547086 Change-Id: Iddb72962bd5f7de1ee9346cda3094e98e0565119 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6119280 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> Cr-Commit-Position: refs/heads/main@{#97920}
1 parent c4317b0 commit 8296db8

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// Copyright (C) 2024 the V8 project authors. All rights reserved.
2+
// This code is governed by the BSD license found in the LICENSE file.
3+
4+
/*---
5+
description: |
6+
AsyncDisposableStack resolved with undefned.
7+
includes: [asyncHelpers.js]
8+
flags: [async]
9+
features: [explicit-resource-management]
10+
---*/
11+
12+
asyncTest(async function() {
13+
async function TestAsyncDisposableStackDefer() {
14+
let stack = new AsyncDisposableStack();
15+
assert.sameValue(await stack.disposeAsync(), undefined);
16+
};
17+
await TestAsyncDisposableStackDefer();
18+
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// Copyright (C) 2024 the V8 project authors. All rights reserved.
2+
// This code is governed by the BSD license found in the LICENSE file.
3+
4+
/*---
5+
description: |
6+
DisposableStack return undefned.
7+
features: [explicit-resource-management]
8+
---*/
9+
10+
(function TestDisposableStackDisposeReturnsUndefined() {
11+
let stack = new DisposableStack();
12+
assert.sameValue(stack.dispose(), undefined);
13+
})();

0 commit comments

Comments
 (0)