Skip to content

Commit a473a2e

Browse files
committed
address comments
1 parent 73aa664 commit a473a2e

11 files changed

+14
-4
lines changed

test/built-ins/Iterator/prototype/drop/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/every/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/filter/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/find/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/flatMap/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/forEach/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/map/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/reduce/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ features: [iterator-helpers]
1111
flags: []
1212
---*/
1313
let nonCallable = {};
14-
let iterator = (function* () {
14+
function* gen() {
1515
yield 1;
16-
})();
16+
}
1717

1818
assert.throws(TypeError, function () {
19-
iterator.reduce(nonCallable);
19+
gen().reduce(nonCallable);
2020
});
2121

22-
iterator.reduce(() => {});
22+
gen().reduce(() => {});

test/built-ins/Iterator/prototype/some/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

test/built-ins/Iterator/prototype/take/argument-validation-failure-closes-underlying.js

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ let closable = {
1919
},
2020
return() {
2121
closed = true;
22+
return {};
2223
},
2324
};
2425

0 commit comments

Comments
 (0)