Skip to content

Commit 64cbca2

Browse files
committed
Revert "feat(helm): add configurable targetPort support for sidecars"
This reverts commit 28adebe.
1 parent 28adebe commit 64cbca2

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

helm/akhq/templates/ingress.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ spec:
4949
service:
5050
name: {{ $fullName }}
5151
port:
52-
name: {{ .Values.service.targetPort | default "http" }}
52+
name: http
5353
{{ else }}
5454
serviceName: {{ $fullName }}
5555
servicePort: http

helm/akhq/templates/service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ spec:
1919
type: {{ .Values.service.type }}
2020
ports:
2121
- port: {{ .Values.service.port }}
22-
targetPort: {{ .Values.service.targetPort | default "http" }}
22+
targetPort: http
2323
protocol: TCP
2424
name: http
2525
{{- if and (eq "NodePort" .Values.service.type) .Values.service.httpNodePort }}
2626
nodePort: {{ .Values.service.httpNodePort }}
2727
{{- end }}
2828
- port: {{ .Values.service.managementPort }}
29-
targetPort: {{ .Values.service.managementTargetPort | default "management" }}
29+
targetPort: management
3030
protocol: TCP
3131
name: management
3232
{{- if and (eq "NodePort" .Values.service.type) .Values.service.managementNodePort }}

helm/akhq/values.yaml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ initContainers: {}
103103
# - mountPath: /tmp
104104
# name: certs
105105

106-
# When using a sidecar (e.g., initContainer with restartPolicy=Always),
107-
# you may want to set service.targetPort to the sidecar port:
108-
# service:
109-
# targetPort: "proxy" # or 4180
110-
111106
# Configure the Pod Security Context
112107
# ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
113108
securityContext: {}
@@ -131,12 +126,6 @@ service:
131126
type: ClusterIP
132127
port: 80
133128
managementPort: 28081
134-
# Configure target ports for the service - useful when using sidecars
135-
# targetPort: "http" # defaults to "http" (port name)
136-
# managementTargetPort: "management" # defaults to "management" (port name)
137-
# Alternative: specify port numbers directly
138-
# targetPort: 8080
139-
# managementTargetPort: 28081
140129
#httpNodePort: 32551
141130
#managementNodePort: 32552
142131
labels: {}

0 commit comments

Comments
 (0)