Merge pull request #106 from DanielYang59/fix-mailto-multi-email

Fix `mailto` handling of multiple recipients

Author: tcort

lib/proto/mailto.js

@@ -6,15 +6,22 @@ module.exports.check = (link, opts, callback) => {
     import('node-email-verifier').then((mod) => {
         const emailValidator = mod.default;
         const address = link
-                            .substr(7)      // strip "mailto:"
-                            .split('?')[0]; // trim ?subject=blah hfields
+            .replace(/^mailto:/i, '')
+            .split('?')[0]; // trim ?subject=blah hfields
 
         /* per RFC6068, the '?' is a reserved delimiter and email addresses containing '?' must be encoded,
          * so it's safe to split on '?' and pick [0].
          */
 
-        emailValidator(address, { checkMx: true, timeout: opts.timeout || '10s' }).then((emailValid) => {
-            if (!emailValid) {
+        // multiple addresses separated by commas
+        const addresses = address.split(',');
+
+        Promise.all(
+            addresses.map(addr =>
+                emailValidator(addr.trim(), { checkMx: true, timeout: opts.timeout || '10s' })
+            )
+        ).then((results) => {
+            if (results.some(valid => !valid)) {
                 return callback(null, new LinkCheckResult(opts, link, 400, null));
             }
             return callback(null, new LinkCheckResult(opts, link, 200, null));

test/link-check.test.js

@@ -268,6 +268,18 @@ describe('link-check', function () {
         });
     });
 
+    it('should handle valid mailto with multiple recipients', function (done) {
+        linkCheck(
+            'MAILTO:[email protected],[email protected]?subject=Test',
+            function (err, result) {
+                expect(err).to.be(null);
+                expect(result.link).to.be('MAILTO:[email protected],[email protected]?subject=Test');
+                expect(result.status).to.be('alive');
+                done();
+            }
+        );
+    });
+
     it('should handle valid mailto with encoded characters in address', function (done) {
         linkCheck('mailto:foo%[email protected]', function (err, result) {
             expect(err).to.be(null);
@@ -304,6 +316,18 @@ describe('link-check', function () {
         });
     });
 
+    it('should handle invalid mailto with multiple recipients', function (done) {
+        linkCheck(
+            'mailto:foo@@bar@@baz,[email protected]?subject=Test',
+            function (err, result) {
+                expect(err).to.be(null);
+                expect(result.link).to.be('mailto:foo@@bar@@baz,[email protected]?subject=Test');
+                expect(result.status).to.be('dead');
+                done();
+            }
+        );
+    });
+
     it('should handle file protocol', function(done) {
         linkCheck('fixtures/file.md', { baseUrl: 'file://' + __dirname }, function(err, result) {
             expect(err).to.be(null);