Skip to content

Conversation

@DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 force-pushed the fix-mailto-multi-email branch 2 times, most recently from 3d9c857 to afaeb2f Compare September 17, 2025 18:05
@DanielYang59 DanielYang59 marked this pull request as draft September 17, 2025 18:05
@DanielYang59 DanielYang59 marked this pull request as ready for review September 17, 2025 18:09
@DanielYang59
Copy link
Contributor Author

@tcort can you please review this? thanks

@tcort
Copy link
Owner

tcort commented Sep 17, 2025

Thanks for the submission! This is a good feature to have.

I think the scheme part of the link (i.e. the mailto: part) is case-insensitive (See RFC3986 Section 6.2.2.1, so please change the regular expression...

            .replace(/^mailto:/, '')

to

            .replace(/^mailto:/i, '')

i.e. add the i after the second / to make it case-insensitive. Once that is done I'll merge.

@DanielYang59
Copy link
Contributor Author

Thanks for the quick reply! great catch, i also updated the test to test case sensitivity

@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Sep 17, 2025

sorry my IDE would auto lint JS, i would revert that

@tcort tcort merged commit 9c4b371 into tcort:master Sep 17, 2025
4 checks passed
@DanielYang59 DanielYang59 deleted the fix-mailto-multi-email branch September 17, 2025 19:06
@tcort
Copy link
Owner

tcort commented Sep 17, 2025

Merged and published in version 5.5.0

@DanielYang59
Copy link
Contributor Author

great to hear! thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mailto: link with multiple emails isn't handled correctly

2 participants