Skip to content

Commit 64096eb

Browse files
committed
update cran comments for 0.2.0
1 parent 1e99847 commit 64096eb

3 files changed

Lines changed: 15 additions & 13 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: tdarec
22
Title: A 'recipes' Extension for Persistent Homology and Its
33
Vectorizations
4-
Version: 0.1.1
4+
Version: 0.2.0
55
Authors@R:
66
person("Jason Cory", "Brunson", , "cornelioid@gmail.com", role = c("cre", "aut"))
77
Description: Topological data analytic methods in machine learning rely on

NEWS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# tdarec 0.1.1
1+
# tdarec 0.2.0
22

33
## column modification - BREAKING CHANGE
44

@@ -8,7 +8,7 @@ Users now also lose access to the data set list-column unless they explicitly du
88

99
## unit tests
1010

11-
This patch debugs the vectorization tests, which had failed to run due to a prefix in the names of the generated test files.
11+
The minor version incorporates a patch to debug the vectorization tests, which had failed to run due to a prefix in the names of the generated test files.
1212
Once corrected, the tent template functions step failed one test due to missing parameters; this has been corrected.
1313

1414
## default scale sequences

cran-comments.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,26 @@
1-
## First submission
1+
## version 0.2.0
2+
3+
This minor version (rather than a patch) is being sooner than planned for two reasons:
4+
5+
1. It makes a change to column transformation naming conventions, recommended by a Tidymodels maintainer, that introduces a breaking change.
6+
2. It revises the taking of minima and maxima for grid defaults to exclude infinities, precluding a bug that would be incurred with an upcoming upgrade to the `Suggests` dependency {ripserr}.
27

3-
This is the first submission of {tdarec} to CRAN.
4-
Version numbers were not incremented during initial development.
58
There are no reverse dependencies on CRAN or Bioconductor.
69

710
## Long-running vignette
811

9-
The vignette is now pre-built to avoid inflating checktime.
12+
The vignette is pre-built to avoid inflating checktime.
1013

1114
## R CMD checks
1215

1316
### Test environments
1417

15-
* local OS X install, R 4.2.3, with {TDAvec} 0.1.3 (GitHub; in development beyond 0.1.4)
18+
All local tests used {TDAvec} version 0.1.41.
19+
20+
* local OS X install, R 4.2.3
1621
* `devtools::check()`
1722
* `devtools::check(env_vars = c('_R_CHECK_DEPENDS_ONLY_' = "true"))`
18-
* local OS X install, R 4.4.2, with {TDAvec} 0.1.4 (CRAN)
23+
* local OS X install, R 4.4.2
1924
* `devtools::check()`
2025
* `devtools::check(env_vars = c('_R_CHECK_DEPENDS_ONLY_' = "true"))`
2126
* `devtools::check(manual = TRUE, remote = TRUE)`
@@ -29,9 +34,6 @@ The vignette is now pre-built to avoid inflating checktime.
2934
There were no ERRORs or WARNINGs.
3035
An occasional NOTE was presumably due to Internet connection speeds.
3136

32-
The exception, with CRAN incoming checks and manual build, also NOTEd that this is a new submission.
33-
3437
### Win-Builder results
3538

36-
In addition to the package being a new submission, these checks NOTEd the words "vectorization(s)" and "vectorizing" used throughout the package and the words "Silge", "Tidymodels", "al" (part of "&al"), and "modularizes".
37-
All are spelled as intended.
39+
There were no ERRORs, WARNINGs, or NOTEs.

0 commit comments

Comments
 (0)