diff --git a/package.json b/package.json index f51d9a7..3b55291 100644 --- a/package.json +++ b/package.json @@ -102,5 +102,8 @@ "react-test-renderer": "17.0.2", "shelljs": "0.8.4" }, - "bugs": "https://github.com/teafuljs/teaful/issues" + "bugs": "https://github.com/teafuljs/teaful/issues", + "dependencies": { + "use-sync-external-store": "^1.2.0" + } } diff --git a/package/index.js b/package/index.js index 055aeb2..bb806c0 100644 --- a/package/index.js +++ b/package/index.js @@ -1,4 +1,5 @@ import {useEffect, useReducer, createElement} from 'react'; +import {useSyncExternalStore} from 'use-sync-external-store/shim'; let MODE_GET = 1; let MODE_USE = 2; diff --git a/tests/getStore.test.js b/tests/getStore.test.js index fd2b972..a8156a9 100644 --- a/tests/getStore.test.js +++ b/tests/getStore.test.js @@ -134,5 +134,5 @@ describe('getStore', () => { expect(screen.getByTestId('items').textContent).toContain('firstElement'); act(() => push(items, 'secondElement')); expect(screen.getByTestId('items').textContent).toContain('firstElement,secondElement'); - }) + }); }); diff --git a/tests/issue88.test.js b/tests/issue88.test.js new file mode 100644 index 0000000..a1e6d17 --- /dev/null +++ b/tests/issue88.test.js @@ -0,0 +1,65 @@ +import {render} from '@testing-library/react'; +import {useEffect, useState} from 'react'; + +import '@babel/polyfill'; + +import createStore from '../package/index'; + +describe('Issue 88', () => { + it('should subscribe even if initially not rendered', () => { + const track = jest.fn(); + + const initialStore = { + number: 0, + }; + const {useStore} = createStore(initialStore); + + const AA = () => { + const [number] = useStore.number(); + track(`AA number: ${number}`); + + return number; + }; + + const CC = () => { + const [number, setNumber] = useStore.number(); + track(`CC number: ${number}`); + if (!number) { + setNumber((prev) => prev + 1); + } + + return 'c'; + }; + + function App() { + const [show, setShow] = useState(false); + track(`App show: ${show}`); + useEffect(() => { + setShow(true); + }, []); + + return ( +