Fixes issue when newly added rows are missing from file

larsve · larsve · commit 9f8dba7ce966 · 2025-04-04T16:54:26.000+02:00
If a sheet were renamed and then new rows were added, the new rows would not
be saved in the .xlsx-file.

To fix that, makeCellKeyRowPrefix() and makeCellKey() were updated to use
cellStoreName, so they use the same key-prefix as makeRowKey does.
diff --git a/row.go b/row.go
@@ -84,15 +84,15 @@ func (r *Row) PushCell(c *Cell) {
 }
 
 func (r *Row) makeCellKey(colIdx int) string {
-	return fmt.Sprintf("%s:%06d:%06d", r.Sheet.Name, r.num, colIdx)
+	return fmt.Sprintf("%s:%06d:%06d", r.Sheet.cellStoreName, r.num, colIdx)
 }
 
 func (r *Row) key() string {
 	return r.makeCellKeyRowPrefix()
 }
 
 func (r *Row) makeCellKeyRowPrefix() string {
-	return fmt.Sprintf("%s:%06d", r.Sheet.Name, r.num)
+	return fmt.Sprintf("%s:%06d", r.Sheet.cellStoreName, r.num)
 }
 
 // GetCell returns the Cell at a given column index, creating it if it doesn't exist.

Original file line number	Diff line number	Diff line change
`@@ -84,15 +84,15 @@ func (r Row) PushCell(c Cell) {`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`func (r *Row) makeCellKey(colIdx int) string {`
`87`		`- return fmt.Sprintf("%s:%06d:%06d", r.Sheet.Name, r.num, colIdx)`
	`87`	`+ return fmt.Sprintf("%s:%06d:%06d", r.Sheet.cellStoreName, r.num, colIdx)`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`func (r *Row) key() string {`
`91`	`91`	`return r.makeCellKeyRowPrefix()`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`func (r *Row) makeCellKeyRowPrefix() string {`
`95`		`- return fmt.Sprintf("%s:%06d", r.Sheet.Name, r.num)`
	`95`	`+ return fmt.Sprintf("%s:%06d", r.Sheet.cellStoreName, r.num)`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`// GetCell returns the Cell at a given column index, creating it if it doesn't exist.`