fix: use consistent underscored subject name for form param keys (#728)

Remove `slugify()` from the `as:` option and `get_params/2` in all
form components. The `as:` option determines the key under which form
params are nested, and `get_params/2` extracts them back out. These
must match each other AND the ash_authentication plugs, which use
`to_string()` without slugification.

Previously some components slugified (producing `"admin-user"`) while
others didn't (producing `"admin_user"`), and the plugs always expected
the underscored form. This caused silent param lookup failures for
multi-word subject names like `AdminUser`.

Closes #726

Author: jimsynz

lib/ash_authentication_phoenix/components/confirm/form.ex

@@ -161,7 +161,6 @@ defmodule AshAuthentication.Phoenix.Components.Confirm.Form do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/magic_link.ex

@@ -173,7 +173,6 @@ defmodule AshAuthentication.Phoenix.Components.MagicLink do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/password/register_form.ex

@@ -239,7 +239,6 @@ defmodule AshAuthentication.Phoenix.Components.Password.RegisterForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/password/reset_form.ex

@@ -189,7 +189,6 @@ defmodule AshAuthentication.Phoenix.Components.Password.ResetForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/password/sign_in_form.ex

@@ -103,7 +103,7 @@ defmodule AshAuthentication.Phoenix.Components.Password.SignInForm do
       strategy.resource
       |> Form.for_action(strategy.sign_in_action_name,
         domain: domain,
-        as: subject_name |> to_string() |> slugify(),
+        as: subject_name |> to_string(),
         id:
           "#{subject_name}-#{Strategy.name(strategy)}-#{strategy.sign_in_action_name}"
           |> slugify(),
@@ -250,7 +250,6 @@ defmodule AshAuthentication.Phoenix.Components.Password.SignInForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/recovery_code/verify_form.ex

@@ -97,7 +97,7 @@ defmodule AshAuthentication.Phoenix.Components.RecoveryCode.VerifyForm do
           resource
           |> Form.for_action(strategy.verify_action_name,
             domain: domain,
-            as: subject_name |> to_string() |> slugify(),
+            as: subject_name |> to_string(),
             id:
               "#{subject_name}-#{Strategy.name(strategy)}-verify-recovery-code"
               |> slugify(),
@@ -240,7 +240,6 @@ defmodule AshAuthentication.Phoenix.Components.RecoveryCode.VerifyForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/reset/form.ex

@@ -202,7 +202,6 @@ defmodule AshAuthentication.Phoenix.Components.Reset.Form do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/totp/setup_form.ex

@@ -271,7 +271,7 @@ if Code.ensure_loaded?(EQRCode) do
         strategy.resource
         |> Form.for_action(strategy.confirm_setup_action_name,
           domain: domain,
-          as: subject_name |> to_string() |> slugify(),
+          as: subject_name |> to_string(),
           id:
             "#{subject_name}-#{Strategy.name(strategy)}-#{strategy.confirm_setup_action_name}"
             |> slugify(),
@@ -342,7 +342,6 @@ if Code.ensure_loaded?(EQRCode) do
         strategy.resource
         |> Info.authentication_subject_name!()
         |> to_string()
-        |> slugify()
 
       Map.get(params, param_key, %{})
     end

lib/ash_authentication_phoenix/components/totp/sign_in_form.ex

@@ -88,7 +88,7 @@ defmodule AshAuthentication.Phoenix.Components.Totp.SignInForm do
       strategy.resource
       |> Form.for_action(strategy.sign_in_action_name,
         domain: domain,
-        as: subject_name |> to_string() |> slugify(),
+        as: subject_name |> to_string(),
         id:
           "#{subject_name}-#{Strategy.name(strategy)}-#{strategy.sign_in_action_name}"
           |> slugify(),
@@ -189,7 +189,6 @@ defmodule AshAuthentication.Phoenix.Components.Totp.SignInForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end

lib/ash_authentication_phoenix/components/totp/verify_2fa_form.ex

@@ -120,7 +120,7 @@ defmodule AshAuthentication.Phoenix.Components.Totp.Verify2faForm do
           resource
           |> Form.for_action(strategy.verify_action_name,
             domain: domain,
-            as: subject_name |> to_string() |> slugify(),
+            as: subject_name |> to_string(),
             id:
               "#{subject_name}-#{Strategy.name(strategy)}-verify-2fa"
               |> slugify(),
@@ -276,7 +276,6 @@ defmodule AshAuthentication.Phoenix.Components.Totp.Verify2faForm do
       strategy.resource
       |> Info.authentication_subject_name!()
       |> to_string()
-      |> slugify()
 
     Map.get(params, param_key, %{})
   end