Skip to content

Commit 8e23de6

Browse files
committed
fix: remove profile image logics when login
1 parent 91f10fc commit 8e23de6

File tree

6 files changed

+3
-42
lines changed

6 files changed

+3
-42
lines changed

src/main/java/org/fontory/fontorybe/member/controller/port/MemberOnboardService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@
77

88
public interface MemberOnboardService {
99
Member fetchOrCreateMember(Provide p);
10-
Member initNewMemberInfo(Long requestMemberId, InitMemberInfoRequest initMemberInfoRequest, FileUploadResult fileUploadResult);
1110
Member initNewMemberInfo(Long requestMemberId, InitMemberInfoRequest initMemberInfoRequest);
1211
}

src/main/java/org/fontory/fontorybe/member/domain/Member.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,6 @@ public static Member fromDefaults(MemberDefaults memberDefaults, String nickname
4343
.build();
4444
}
4545

46-
public Member initNewMemberInfo(InitMemberInfoRequest initNewMemberInfo, String profileImageKey) {
47-
return Member.builder()
48-
.id(this.id)
49-
.nickname(initNewMemberInfo.getNickname())
50-
.gender(initNewMemberInfo.getGender())
51-
.birth(initNewMemberInfo.getBirth())
52-
.createdAt(this.createdAt)
53-
.provideId(this.provideId)
54-
.deletedAt(this.deletedAt)
55-
.provideId(this.provideId)
56-
.status(MemberStatus.ACTIVATE)
57-
.build();
58-
}
59-
6046
public Member initNewMemberInfo(InitMemberInfoRequest initNewMemberInfo) {
6147
return Member.builder()
6248
.id(this.id)

src/main/java/org/fontory/fontorybe/member/domain/MemberDefaults.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,11 @@
1313
@ConfigurationProperties(prefix="member.default")
1414
public class MemberDefaults {
1515
private LocalDate birth;
16-
private String profileImageKey;
1716
private Gender gender;
1817

1918
@ConstructorBinding
20-
public MemberDefaults(LocalDate birth,
21-
String profileImageKey) {
19+
public MemberDefaults(LocalDate birth) {
2220
this.birth = birth;
23-
this.profileImageKey = profileImageKey;
2421
this.gender = Gender.NONE;
2522
}
2623
}

src/main/java/org/fontory/fontorybe/member/service/MemberOnboardServiceImpl.java

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,24 +40,6 @@ public Member fetchOrCreateMember(Provide p) {
4040
}
4141
}
4242

43-
@Override
44-
@Transactional
45-
public Member initNewMemberInfo(Long requestMemberId,
46-
InitMemberInfoRequest initNewMemberInfoRequest,
47-
FileUploadResult fileUploadResult) {
48-
Member targetMember = memberLookupService.getOrThrowById(requestMemberId);
49-
FileMetadata fileMetadata = fileService.getOrThrowById(fileUploadResult.getId());
50-
if (targetMember.getStatus() == MemberStatus.ACTIVATE) {
51-
throw new MemberAlreadyJoinedException();
52-
} else if (memberLookupService.existsByNickname(initNewMemberInfoRequest.getNickname())) {
53-
throw new MemberDuplicateNameExistsException();
54-
}
55-
56-
checkContainsBadWord(initNewMemberInfoRequest.getNickname());
57-
58-
return memberRepository.save(targetMember.initNewMemberInfo(initNewMemberInfoRequest, fileMetadata.getKey()));
59-
}
60-
6143
@Override
6244
@Transactional
6345
public Member initNewMemberInfo(Long requestMemberId,

src/main/resources/application.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ api.server.url=http://localhost:8080
1313

1414
spring.config.import=optional:classpath:application-infrastructure.properties
1515
url.base=http://localhost
16-
url.path.signup=/signup/step-one
16+
url.path.signup=/signup
1717
url.path.auth=
1818
url.cdn=https://cdn.fontory.co.kr
1919

src/test/java/org/fontory/fontorybe/unit/mock/TestContainer.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import org.fontory.fontorybe.file.application.port.CloudStorageService;
1616
import org.fontory.fontorybe.file.application.port.FileRepository;
1717
import org.fontory.fontorybe.file.application.port.FileService;
18-
import org.fontory.fontorybe.file.domain.FileUploadResult;
1918
import org.fontory.fontorybe.member.controller.MemberController;
2019
import org.fontory.fontorybe.member.controller.ProfileController;
2120
import org.fontory.fontorybe.member.controller.RegistrationController;
@@ -38,7 +37,6 @@
3837
import org.fontory.fontorybe.provide.service.port.ProvideRepository;
3938
import org.springframework.context.ApplicationEventPublisher;
4039
import org.springframework.mock.web.MockMultipartFile;
41-
import org.springframework.web.multipart.MultipartFile;
4240

4341
import javax.crypto.KeyGenerator;
4442
import javax.crypto.SecretKey;
@@ -138,8 +136,7 @@ public TestContainer() {
138136
.build();
139137

140138
memberDefaults = new MemberDefaults(
141-
LocalDate.of(1999, 12, 31),
142-
DEFAULT_PROFILE_KEY);
139+
LocalDate.of(1999, 12, 31));
143140

144141
fileService = FileServiceImpl.builder()
145142
.memberLookupService(memberLookupService)

0 commit comments

Comments
 (0)