Merge pull request #180 from team-gogo/fix/coupon-query-api-specs

Author: vumrra

src/main/kotlin/gogo/gogostage/domain/coupon/root/application/CouponServiceImpl.kt

@@ -2,9 +2,7 @@ package gogo.gogostage.domain.coupon.root.application
 
 import gogo.gogostage.domain.coupon.root.application.dto.QueryCouponDto
 import gogo.gogostage.domain.coupon.root.application.dto.UseCouponDto
-import gogo.gogostage.domain.coupon.root.persistence.Coupon
 import gogo.gogostage.domain.stage.root.application.StageValidator
-import gogo.gogostage.global.internal.student.stub.StudentByIdStub
 import gogo.gogostage.global.util.UserContextUtil
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
@@ -23,22 +21,18 @@ class CouponServiceImpl(
     override fun query(couponId: String): QueryCouponDto {
         val student = userUtil.getCurrentStudent()
         val coupon = couponReader.read(couponId)
-        valid(student, coupon)
+        stageValidator.validStage(student, coupon.stage.id)
         return couponMapper.map(coupon)
     }
 
     @Transactional
     override fun use(couponId: String): UseCouponDto {
         val student = userUtil.getCurrentStudent()
         val coupon = couponReader.readForUpdate(couponId)
-        valid(student, coupon)
-        val couponResult = couponProcessor.use(student, coupon)
-        return couponMapper.mapResult(coupon, couponResult)
-    }
-
-    private fun valid(student: StudentByIdStub, coupon: Coupon) {
         couponValidator.valid(coupon)
         stageValidator.validStage(student, coupon.stage.id)
+        val couponResult = couponProcessor.use(student, coupon)
+        return couponMapper.mapResult(coupon, couponResult)
     }
 
 }