fix: various fixes for all versions & cleanup left over configs

ocombe · ocombe · commit b81802135406 · 2023-10-16T11:29:43.000+02:00
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -264,7 +264,7 @@ jobs:
         run: bit test --log
 
       - name: Bit build
-        run: bit build --log
+        run: NODE_OPTIONS=--openssl-legacy-provider bit build --log
 
       - uses: actions/upload-artifact@v3
         with:
diff --git a/angular/devkit/common/component.json b/angular/devkit/common/component.json
@@ -16,7 +16,6 @@
           "typescript": ">= 3.5.3"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/compiler/elements/component.json b/angular/devkit/compiler/elements/component.json
@@ -46,7 +46,6 @@
           "@babel/runtime": "7.22.15"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/compiler/multi-compiler/component.json b/angular/devkit/compiler/multi-compiler/component.json
@@ -21,7 +21,6 @@
           "@angular/compiler-cli": ">= 8.0.0"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/compiler/ng-packagr/component.json b/angular/devkit/compiler/ng-packagr/component.json
@@ -17,7 +17,6 @@
           "ng-packagr": ">=5.0.0"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/linter/eslint/component.json b/angular/devkit/linter/eslint/component.json
@@ -20,7 +20,6 @@
           "eslint": ">= 7.0.0"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/linter/eslint/config/tsconfig.json b/angular/devkit/linter/eslint/config/tsconfig.json
@@ -1,27 +1,33 @@
 {
   "compilerOptions": {
+    "allowJs": true,
     "baseUrl": "./",
     "declaration": false,
     "downlevelIteration": true,
+    "emitDecoratorMetadata": true,
+    "esModuleInterop": true,
     "experimentalDecorators": true,
     "forceConsistentCasingInFileNames": true,
     "importHelpers": true,
     "jsx": "react-jsx",
     "lib": [
       "es2018",
+      "ESNext",
       "dom"
     ],
     "module": "esnext",
     "moduleResolution": "node",
     "noFallthroughCasesInSwitch": true,
     "noImplicitReturns": true,
     "outDir": "./dist/out-tsc",
+    "preserveSymlinks": true,
+    "skipLibCheck": true,
     "sourceMap": true,
     "strict": true,
-    "target": "es2015",
-    "allowJs": true
+    "target": "es2015"
   },
   "exclude": ["artifacts", "public", "dist", "node_modules", "package.json"],
+  "include": ["**/*", "**/*.json"],
   "angularCompilerOptions": {
     "enableI18nLegacyMessageIdFormat": false,
     "strictInjectionParameters": true,
diff --git a/angular/devkit/ng-compat/component.json b/angular/devkit/ng-compat/component.json
@@ -15,7 +15,6 @@
           "webpack": ">= 4.44.2"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/ngcc/component.json b/angular/devkit/ngcc/component.json
@@ -14,7 +14,6 @@
           "@angular/compiler-cli": ">= 8.0.0"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/preview/mounter/component.json b/angular/devkit/preview/mounter/component.json
@@ -19,7 +19,6 @@
           "zone.js": ">= 0.9.1"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/preview/preview/component.json b/angular/devkit/preview/preview/component.json
@@ -26,7 +26,6 @@
           "zone.js": ">= 0.9.1"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/preview/runtime/component.json b/angular/devkit/preview/runtime/component.json
@@ -18,7 +18,6 @@
           "zone.js": ">= 0.9.1"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/devkit/webpack/component.json b/angular/devkit/webpack/component.json
@@ -19,7 +19,6 @@
           "@babel/runtime": "7.22.15"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/angular/envs/angular-v12-env/component.json b/angular/envs/angular-v12-env/component.json
@@ -14,9 +14,9 @@
           "@angular-devkit/build-webpack": "~0.1202.16",
           "@angular-devkit/core": "^12.2.16",
           "@angular-devkit/schematics": "^12.2.16",
-          "@angular-eslint/eslint-plugin": "^12.1.0",
-          "@angular-eslint/eslint-plugin-template": "^12.1.0",
-          "@angular-eslint/template-parser": "^12.1.0",
+          "@angular-eslint/eslint-plugin": "~13.0.1",
+          "@angular-eslint/eslint-plugin-template": "~13.0.1",
+          "@angular-eslint/template-parser": "~13.0.1",
           "@angular/animations": "^12.2.16",
           "@angular/cli": "~12.2.16",
           "@angular/common": "^12.2.16",
@@ -27,15 +27,15 @@
           "@angular/platform-browser": "^12.2.16",
           "@angular/platform-browser-dynamic": "^12.2.16",
           "@ngtools/webpack": "^12.2.16",
-          "@types/eslint": "^7.28.0",
+          "@types/eslint": "^8.2.0",
           "@types/jest": "~27.0.1",
           "@types/react-dev-utils": "~9.0.8",
           "@types/remark-prism": "~1.3.0",
           "@types/webpack-dev-server": "4.3.1",
           "@types/webpack-dev-middleware": "5.0.2",
-          "@typescript-eslint/eslint-plugin": "^4.26.0",
-          "@typescript-eslint/parser": "^4.26.0",
-          "eslint": "7.26.0",
+          "@typescript-eslint/eslint-plugin": "^5.3.0",
+          "@typescript-eslint/parser": "^5.3.0",
+          "eslint": "8.2.0",
           "events": "^3.2.0",
           "html-loader": "~2.1.2",
           "jest": "~27.0.4",
diff --git a/angular/envs/angular-v17-env/webpack-config.factory.ts b/angular/envs/angular-v17-env/webpack-config.factory.ts
@@ -132,7 +132,6 @@ async function getWebpackConfig(
     ...logger,
     log: logger.console
   } as any as logging.LoggerApi;
-  console.log(browserOptions);
   const normalizedOptions = normalizeBrowserSchema(
     normalizedWorkspaceRoot,
     projectRoot,
diff --git a/angular/envs/base-env/component.json b/angular/envs/base-env/component.json
@@ -52,7 +52,6 @@
           "zone.js": ">= 0.9.1"
         }
       }
-    },
-    "teambit.node/node@1.0.16": {}
+    }
   }
 }
diff --git a/workspace.jsonc b/workspace.jsonc
@@ -22,7 +22,7 @@
     /**
      * default scope for all components in workspace.
      **/
-    "defaultScope": "bitdev.angular",
+    "defaultScope": "integration.examples",
     "resolveEnvsFromRoots": true
   },
   /**

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`"typescript": ">= 3.5.3"`
`17`	`17`	`}`
`18`	`18`	`}`
`19`		`- },`
`20`		`- "teambit.node/[email protected]": {}`
	`19`	`+ }`
`21`	`20`	`}`
`22`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@`
`46`	`46`	`"@babel/runtime": "7.22.15"`
`47`	`47`	`}`
`48`	`48`	`}`
`49`		`- },`
`50`		`- "teambit.node/[email protected]": {}`
	`49`	`+ }`
`51`	`50`	`}`
`52`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`"@angular/compiler-cli": ">= 8.0.0"`
`22`	`22`	`}`
`23`	`23`	`}`
`24`		`- },`
`25`		`- "teambit.node/[email protected]": {}`
	`24`	`+ }`
`26`	`25`	`}`
`27`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`"ng-packagr": ">=5.0.0"`
`18`	`18`	`}`
`19`	`19`	`}`
`20`		`- },`
`21`		`- "teambit.node/[email protected]": {}`
	`20`	`+ }`
`22`	`21`	`}`
`23`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@`
`20`	`20`	`"eslint": ">= 7.0.0"`
`21`	`21`	`}`
`22`	`22`	`}`
`23`		`- },`
`24`		`- "teambit.node/[email protected]": {}`
	`23`	`+ }`
`25`	`24`	`}`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`"webpack": ">= 4.44.2"`
`16`	`16`	`}`
`17`	`17`	`}`
`18`		`- },`
`19`		`- "teambit.node/[email protected]": {}`
	`18`	`+ }`
`20`	`19`	`}`
`21`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@`
`14`	`14`	`"@angular/compiler-cli": ">= 8.0.0"`
`15`	`15`	`}`
`16`	`16`	`}`
`17`		`- },`
`18`		`- "teambit.node/[email protected]": {}`
	`17`	`+ }`
`19`	`18`	`}`
`20`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`"zone.js": ">= 0.9.1"`
`20`	`20`	`}`
`21`	`21`	`}`
`22`		`- },`
`23`		`- "teambit.node/[email protected]": {}`
	`22`	`+ }`
`24`	`23`	`}`
`25`	`24`	`}`