-
-
Notifications
You must be signed in to change notification settings - Fork 296
Open
Description
Current:
Lines 222 to 226 in 781e0ee
| if (count($stack)) { | |
| $docs = new Collection($stack[0]); | |
| } else { | |
| $docs = new Collection; | |
| } |
Suggestion:
if (count($stack)) {
$docs = new Collection(array_combine($stack[0],$stack[0]));
} else {
$docs = new Collection;
}Reason:
When following Build an Index Manually Without a Datastore (no initial seeding of index) you can't get the correct IDs from searchBoolean with driver filesystem otherwise, because:
if ($this->isFileSystemIndex()) {
return $this->filesystemMapIdsToPaths($docs)->toArray();
}Returns 0,1,2,3, mapped to empty strings instead (unlike for "search" function, where the array key is the correct docId).
Metadata
Metadata
Assignees
Labels
No labels