Provision support for `PROXY` url.

[Sachin796]

I am currently trying to use the gem to connect to the Pagerduty API from a server which only allows proxy url to access the internet. I would like to request a feature where you can make provisions to allow proxy parameter when we create Pagerduty::Connection.new, and when it actually connects using Faraday here . Below is the screenshot of the error that I am getting.

When I create my own connection using Faraday with the proxy key, it works fine, connects to Pagerduty API and does all the operations. But I would like to use the gem for other features but with this support inbuilt.

[technicalpickles]

I'm not actively working on this, but would be happy to review code to include a feature like this. I'm curious if there are any conventions that other API libraries follow for conventions. I have not seen any myself, but I haven't really used a proxy before.

If there is a good way to do it within Faraday, @connection has an attr accessor, so one thing you could do is make changes to it for testing.

[Sachin796]

Thanks for the reply.
As I mentioned the above screenshot works for me.. but it does have its own limitations that I am currently facing issue with. It has some issue's related to Connection Timeout, so I wanted to replace that with what the gem can provide.

There is one more gem that pagerduty recommends from their end for other tasks. I have seen that gem implementing this functionality in the here.

I am not sure how efficiently it is working but pretty sure that it handles the proxy error that I am facing.

[technicalpickles]

We are using the faraday gem, so I was googling "faraday proxy", and came across these docs

Faraday will try to automatically infer the proxy settings from your system using URI#find_proxy. This will retrieve them from environment variables such as http_proxy, ftp_proxy, no_proxy, etc. If for any reason you want to disable this behavior, you can do so by setting the global variable ignore_env_proxy:

Faraday.ignore_env_proxy = true

You can also specify a custom proxy when initializing the connection:

conn = Faraday.new('http://www.example.com', proxy: 'http://proxy.com')

URI.find_proxy says:

The proxy URI is obtained from environment variables such as http_proxy, ftp_proxy, no_proxy, etc. If there is no proper proxy, nil is returned.

If the optional parameter env is specified, it is used instead of ENV.

Note that capitalized variables (HTTP_PROXY, FTP_PROXY, NO_PROXY, etc.) are examined, too.

But http_proxy and HTTP_PROXY is treated specially under CGI environment. It’s because HTTP_PROXY may be set by Proxy: header. So HTTP_PROXY is not used. http_proxy is not used too if the variable is case insensitive. CGI_HTTP_PROXY can be used instead.

Given that, it seems that setting HTTP_PROXY should work. Can you try that and see if it works? If it doesn't, maybe we need a newer faraday version dependency.

And failing that, it should be straightforward to make it configurable from the constructor and/or a proxy environment variable.

[Sachin796]

Hi,
Thank you for the suggestions. I understood what you are saying. I have tried the first suggestion in the message above. I have verified that the HTTP_PROXY env variable was already set while I was running my application. The issue that I had mentioned where it gave me SSL connect error, was along with the environment variable HTTP_PROXY already been set. So I think whatever was mentioned in the documentation did not work out.
Can we proceed with the other approach..?.. which included newer faraday version dependency. As per my understanding, I think this should be the changes that are to be made in the gem itself. I want to try that approach and test it out as well. And it that doesn't work out .. we can proceed with the final approach that you mentioned.

Thanks.