Skip to content

Commit 4cb79c9

Browse files
dhensbyCopilot
andcommitted
ci: disable fail-fast on the windows test matrix
The test-windows job did not set fail-fast, so GitHub Actions defaulted to fail-fast: true. A single transient failure — often during the multi-minute SQL Server setup phase — cancelled every other in-progress and queued sibling job in the windows matrix. Those cancelled jobs would otherwise have passed, and re-running forced the entire expensive setup to be redone for all combinations. The test-linux matrix intentionally keeps fail-fast enabled: those jobs bootstrap much faster, and because test-windows needs test-linux, a linux failure should stop the run before the slower windows matrix starts rather than wasting time on it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent bcb8267 commit 4cb79c9

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ jobs:
113113
env:
114114
MSSQL_PASSWORD: 'yourStrong(!)Password'
115115
strategy:
116+
fail-fast: false
116117
matrix:
117118
os: [windows-2022, windows-2025]
118119
node: [18.x, 20.x, 22.x, 24.x]

0 commit comments

Comments
 (0)