Addressing feedback

Author: martinhoyer

tmt/steps/execute/__init__.py

@@ -160,10 +160,6 @@ def cleanup(self) -> None:
             self._rendered_script_path.unlink()
             self._rendered_script_path = None
 
-    def keep_rendered_file(self) -> None:
-        """Prevents automatic deletion on __exit__."""
-        self._delete_on_exit = False
-
 
 def effective_scripts_dest_dir(default: Path = DEFAULT_SCRIPTS_DEST_DIR) -> Path:
     """
@@ -839,7 +835,7 @@ def prepare_scripts(self, guest: "tmt.steps.provision.Guest") -> None:
             with script as source:
                 # If it's a template, prevent immediate cleanup and track it
                 if isinstance(script, ScriptTemplate):
-                    script.keep_rendered_file()
+                    script._delete_on_exit = False  # Prevent cleanup before push
                     templates_to_cleanup.append(script)
                     # Use the actual rendered path as the source
                     source_path = script._rendered_script_path

tmt/steps/provision/__init__.py

@@ -2447,22 +2447,19 @@ def push(
             destination = Path("/")
 
         sources: list[Path]
-        log_message: str
 
         if source is None:
             # FIXME: cast() - https://github.com/teemtee/tmt/issues/1372
             parent = cast(Provision, self.parent)
             assert parent.plan.workdir is not None
             sources = [parent.plan.workdir]
-            log_message = f"Push workdir to guest '{self.primary_address}'."
+            self.debug(f"Push workdir to guest '{self.primary_address}'.")
         elif isinstance(source, Path):
             sources = [source]
-            log_message = f"Copy '{source}' to '{destination}' on the guest."
+            self.debug(f"Copy '{source}' to '{destination}' on the guest.")
         else:  # source is a list of Paths
             sources = source
-            log_message = f"Copy {len(sources)} files/dirs to '{destination}' on the guest."
-
-        self.debug(log_message)
+            self.debug(f"Copy {len(sources)} files/dirs to '{destination}' on the guest.")
 
         def rsync() -> None:
             """Run the rsync command"""

tmt/steps/provision/podman.py

@@ -491,7 +491,12 @@ def push(
             for src in sources:
                 source_spec = f"{container_name}:{src}" if container_name else str(src)
                 dest_spec = f"{self.container}:{destination}"
-                self.podman(Command("cp", source_spec, dest_spec))
+                try:
+                    self.podman(Command("cp", source_spec, dest_spec))
+                except tmt.utils.RunError as err:
+                    raise tmt.utils.ProvisionError(
+                        f"Failed to copy '{src}' to '{destination}': {err}"
+                    ) from err
 
     def pull(
         self,