squash: address comments

Author: happz

tmt/result.py

@@ -1,5 +1,15 @@
 import enum
-from typing import TYPE_CHECKING, Any, Callable, Optional, TypeVar, cast
+from typing import (
+    TYPE_CHECKING,
+    Any,
+    Callable,
+    Optional,
+    SupportsIndex,
+    TypeVar,
+    Union,
+    cast,
+    overload,
+)
 
 import fmf.utils
 
@@ -536,6 +546,26 @@ class Results(list[ResultT]):
     the collection as a whole.
     """
 
+    @overload
+    def __getitem__(self, i: SupportsIndex) -> ResultT:
+        pass
+
+    @overload
+    def __getitem__(self, i: slice) -> 'Results[ResultT]':
+        pass
+
+    def __getitem__(self, i: Union[SupportsIndex, slice]) -> Union[ResultT, 'Results[ResultT]']:
+        if isinstance(i, slice):
+            return Results(super().__getitem__(i))
+
+        return super().__getitem__(i)
+
+    def __add__(self, other: 'Results[ResultT]') -> 'Results[ResultT]':  # type: ignore[override]
+        return Results(super().__add__(other))
+
+    def copy(self) -> 'Results[ResultT]':
+        return Results(super().copy())
+
     def total(self) -> dict[ResultOutcome, int]:
         """
         Return dictionary with total stats.

tmt/steps/__init__.py

@@ -1005,7 +1005,7 @@ def _load_results(
         self,
         result_class: type[ResultT],
         allow_missing: bool = False,
-    ) -> tmt.result.Results[ResultT]:
+    ) -> Results[ResultT]:
         """
         Load results of this step from the workdir
         """

tmt/steps/execute/__init__.py

@@ -767,7 +767,7 @@ def prepare_tests(self, guest: Guest, logger: tmt.log.Logger) -> list[TestInvoca
         if self.should_run_again:
             assert self.parent is not None  # narrow type
             assert isinstance(self.parent, Execute)  # narrow type
-            self.parent._old_results = Results(self.parent._results[:])
+            self.parent._old_results = self.parent._results.copy()
             self.parent._results.clear()
 
         return invocations
@@ -1342,7 +1342,7 @@ def go(self, force: bool = False) -> None:
 
         self._assert_required_tests_executed()
 
-    def results(self) -> 'tmt.result.Results[tmt.result.Result]':
+    def results(self) -> Results[Result]:
         """
         Results from executed tests