Skip to content

Add renovate #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add renovate #2923

wants to merge 1 commit into from
+20 −0

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented May 9, 2024 •
edited
Loading

Here is a configuration for adding renovate. It's like dependabot but it's far less noisy, allowing to update dependencies when ready instead of whenever dependabot pokes you to do so.

The main benefits over dependabot:

  • group dependencies. Can even group across different systems, e.g. github-action + pre-commit
  • reuse of PR/issues
  • flexibility and configurability. This is just a basic configuration file, there are much more that can be configured here.

For an example, you can check my fork where I've enabled this: LecrisUT#2

To add this the app needs to be installed, and when configuring the settings (403 page because it points to the not-yet configured url), make sure to set it to Renovate -> Mode -> Interactive, otherwise PRs are not created.

Fixes #3504

LecrisUT
LecrisUT commented May 9, 2024
View reviewed changes
@psss psss requested a review from martinhoyer as a code owner March 12, 2025 05:10
@martinhoyer martinhoyer mentioned this pull request Mar 15, 2025
Open
martinhoyer
martinhoyer reviewed Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @LecrisUT, theoretically, do we want renovate or pre-commit.ci to be updating pre-commit hooks? #3604

Isn't the renovate.json going a bit too hard on spacing? :)

@LecrisUT
Copy link
Contributor Author

renovate is a more powerful tool if you need it. It can update GH actions, pre-commit and python dependencies. Python dependencies usage is questionable since it does not account for distro availability, but each group can be separated, so you can track and tackle python dependencies in a separate PR.

Isn't the renovate.json going a bit too hard on spacing? :)

Ah, it was tab separated, my bad.

@martinhoyer
Copy link
Collaborator

martinhoyer commented Mar 17, 2025 •
edited
Loading

renovate is a more powerful tool if you need it. It can update GH actions, pre-commit and python dependencies. Python dependencies usage is questionable since it does not account for distro availability, but each group can be separated, so you can track and tackle python dependencies in a separate PR.

Yep, would make sense to me to have renovate doing the updates to pre-commit as well if it would be implemented for actions and maybee python deps.

btw, Fixes #3504

@LecrisUT
Copy link
Contributor Author

Any ideas why can't I link it?

No clue, but it wouldn't close the issue. Better to edit the description instead (I just did that 🙂 )

@psss psss added this to planning Apr 10, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Apr 10, 2025
@psss psss added this to the 1.47 milestone Apr 10, 2025
@psss psss added documentation Improvements or additions to documentation packaging Changes related to the rpm packaging labels Apr 10, 2025
@happz happz moved this from backlog to review in planning Apr 10, 2025
@martinhoyer martinhoyer mentioned this pull request Apr 11, 2025
Open
@thrix thrix requested a review from martinhoyer April 22, 2025 08:58
thrix
thrix approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try it, seems nice addition.

@happz happz moved this from review to merge in planning Apr 22, 2025
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Apr 22, 2025
@martinhoyer
Copy link
Collaborator

Whoa, just noticed ready to merge here. Adding the app to the repo. It also auto-creates onboarding PR: #3688

psss
psss approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! Let's see how it works :)

@psss psss mentioned this pull request Apr 22, 2025
Open
@martinhoyer
Copy link
Collaborator

Also, can we merge #3662 first, in order for the Renovate not to create pull requests for pre-commit hooks?

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 22, 2025 •
edited
Loading

Also, can we merge #3662 first, in order for the Renovate not to create pull requests for pre-commit hooks?

Should be fine either way, renovate closes its own PRs if all the changes are merged. If there are leftover changes, it will just rebase itself on top of main

@martinhoyer
Copy link
Collaborator

#3688 (comment)

@psss psss modified the milestones: 1.47, 1.48 Apr 23, 2025
@LecrisUT @martinhoyer
Add renovatebot
6096b75 
Signed-off-by: Cristian Le <[email protected]>
@martinhoyer martinhoyer enabled auto-merge (rebase) April 24, 2025 12:54
@happz happz disabled auto-merge April 24, 2025 13:45
@happz happz added the status | blocked The merging of PR is blocked on some other issue label Apr 26, 2025
@happz
Copy link
Collaborator

happz commented Apr 26, 2025

Ok, getting #3662 in first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@thrix thrix thrix approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy

@janhavlin janhavlin Awaiting requested review from janhavlin

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation packaging Changes related to the rpm packaging status | blocked The merging of PR is blocked on some other issue status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
planning
Status: merge
Milestone
1.48
Development

Successfully merging this pull request may close these issues.

Add renovatebot to update regularly the repository
5 participants
@LecrisUT @martinhoyer @happz @thrix @psss