Skip to content

Import plans before filtering by default #4923

@The-Mule

Description

@The-Mule

TMT 1.62 introduced #4261. This make it possible to finally import trees of plans easily. However and rather surprisingly, it requires an option to be enabled. By default only local plans are available for filtering, to get imported plans into the account one need to use --import-before-name-filter (or TMT_IMPORT_BEFORE_FILTER=1). Suppose you have a plan tree under the parent /plan/imported:

plan:
  import:
     url: ...
     name: /plans/imported/
     importing: become-parent
     scope: all-plans

Then with tmt plans:

❯ tmt plans ls /plans/imported/

❯ tmt --import-before-name-filter plans ls /plans/imported/

/plans/imported/plans/imported/a
/plans/imported/plans/imported/b
/plans/imported/plans/imported/c

To me it feels strange to distinguish between imported and local plans by default. In general, I need to have access to all the plans by default and I should not care if they are imported or not, I should not be required to check whether I have imported plans or not. IMHO this is an usability flaw - I can't rely on tmt unless I have additional knowledge about type of plans in the current repository.

I understand the performance overhead that comes with importing plans always and I think that should be adressed by option if need be. Also the overhead is there only if you are actually importing plans and that will most likely not be the case (ie. I don't think imported plans are used that much) and hence having an option not to import plans before filtering rather than having one for import plans before filtering won't really break most of the use cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    backlog
    Status
    triaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions