write progression overflow tests

Author: robstoll

src/main/kotlin/com/tegonal/variist/generators/arbFromProgression.kt

@@ -39,7 +39,7 @@ fun ArbExtensionPoint.fromProgression(progression: IntProgression): ArbArgsGener
 			//TODO 2.1.0 bench at what point it makes sense to calculate it, I just guess that for small progressions
 			// storing it in a list is more efficient and memory is neglectable. But maybe this can be increased to x
 			// or should be decreased to y
-			if (numberOfSteps < 50) fromList(progression.toList())
+			if (numberOfSteps < 50L) fromList(progression.toList())
 			else {
 				// check that toInt() did not overflow
 				if (numberOfSteps == numberOfStepsI.toLong()) {
@@ -66,7 +66,7 @@ fun ArbExtensionPoint.fromProgression(progression: LongProgression): ArbArgsGene
 		-1L -> longFromTo(progression.last, progression.first)
 		else -> {
 			val (start, endInclusive) =
-				if (step > 0) Tuple(progression.first, progression.last)
+				if (step > 0L) Tuple(progression.first, progression.last)
 				else Tuple(progression.last, progression.first)
 			val stepAbs = abs(step)
 			val diff = endInclusive.toBigInt() - start.toBigInt()

src/test/kotlin/com/tegonal/variist/generators/ArbFromProgressionTest.kt

@@ -1,6 +1,11 @@
 package com.tegonal.variist.generators
 
+import ch.tutteli.atrium.api.fluent.en_GB.toBeGreaterThanOrEqualTo
+import ch.tutteli.atrium.api.verbs.expect
 import ch.tutteli.kbox.Tuple
+import com.tegonal.variist.providers.ArgsSource
+import com.tegonal.variist.providers.ArgsSourceOptions
+import org.junit.jupiter.params.ParameterizedTest
 
 class ArbFromProgressionTest : AbstractArbArgsGeneratorTest<Any>() {
 
@@ -10,5 +15,19 @@ class ArbFromProgressionTest : AbstractArbArgsGeneratorTest<Any>() {
 		Tuple("fromLongProgression", modifiedArb.fromProgression(1L..3L step 1), listOf(1L, 2L, 3L)),
 	)
 
-	//TODO 2.0.0 add tests which cover the case that numberOfSteps is out of Int/Long range (i.e. would overflow)
+	@ParameterizedTest
+	@ArgsSource("arbIntNegative")
+	@ArgsSourceOptions(maxArgs = 1)
+	fun intProgression_numberOfSteps_overflow_Int__still_works(from: Int) {
+		expect(arb.fromProgression(from..Int.MAX_VALUE step 1).generate().first())
+			.toBeGreaterThanOrEqualTo(from)
+	}
+
+	@ParameterizedTest
+	@ArgsSource("arbLongNegative")
+	@ArgsSourceOptions(maxArgs = 1)
+	fun longProgression_numberOfSteps_overflow_Long__still_works(from: Long) {
+		expect(arb.fromProgression(from..Long.MAX_VALUE step 1).generate().first())
+			.toBeGreaterThanOrEqualTo(from)
+	}
 }

src/test/kotlin/com/tegonal/variist/generators/OrderedFromProgressionTest.kt

@@ -1,11 +1,15 @@
 package com.tegonal.variist.generators
 
+import ch.tutteli.atrium.api.fluent.en_GB.messageToContain
 import ch.tutteli.atrium.api.fluent.en_GB.toEqual
+import ch.tutteli.atrium.api.fluent.en_GB.toThrow
 import ch.tutteli.atrium.api.verbs.expect
 import ch.tutteli.kbox.Tuple
 import com.tegonal.variist.providers.ArgsRange
 import com.tegonal.variist.providers.ArgsSource
+import com.tegonal.variist.providers.ArgsSourceOptions
 import com.tegonal.variist.utils.repeatForever
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.params.ParameterizedTest
 
 class OrderedFromProgressionTest : AbstractOrderedArgsGeneratorTest<Any>() {
@@ -34,7 +38,38 @@ class OrderedFromProgressionTest : AbstractOrderedArgsGeneratorTest<Any>() {
 		)
 	}
 
-	//TODO 2.0.0 write test for intProgression and longProgression, especially for cases where the range size overflows Int/Long Domain
+	@ParameterizedTest
+	@ArgsSource("arbIntNegative")
+	@ArgsSourceOptions(maxArgs = 1)
+	fun intProgression_numberOfSteps_overflow_Int__throws(from: Int) {
+		expect {
+			ordered.fromProgression(from..Int.MAX_VALUE step 1)
+		}.toThrow<IllegalStateException> {
+			messageToContain("OrderedArgsGenerator.size only supports Int")
+		}
+	}
+
+	@ParameterizedTest
+	@ArgsSource("arbIntNegative")
+	@ArgsSourceOptions(maxArgs = 1)
+	fun longProgression_numberOfSteps_overflow_Int__throws(from: Int) {
+		expect {
+			ordered.fromProgression(from.toLong()..Int.MAX_VALUE.toLong() step 1)
+		}.toThrow<IllegalStateException> {
+			messageToContain("OrderedArgsGenerator.size only supports Int")
+		}
+	}
+
+	@ParameterizedTest
+	@ArgsSource("arbLongNegative")
+	@ArgsSourceOptions(maxArgs = 1)
+	fun longProgression_numberOfSteps_overflow_Long__throws(from: Long) {
+		expect {
+			ordered.fromProgression(from..Long.MAX_VALUE step 1)
+		}.toThrow<IllegalStateException> {
+			messageToContain("OrderedArgsGenerator.size only supports Int")
+		}
+	}
 
 	companion object {
 		@JvmStatic