Refactor NK: Full document creation and test for simple costs.

Author: MarcoSteinacher

django/geno/api_views.py

@@ -79,6 +79,7 @@ class ContractViewSet(viewsets.ReadOnlyModelViewSet):
     # permission_classes = [permissions.IsAuthenticated]
 
 
+# TODO: This is now done directly in report/nk/contract.py => Remove together with legacy code in report/nk_report.py
 class Akonto(APIView):
     """
     Get paid akonto amount for contract and billing period.
@@ -162,6 +163,7 @@ def get_akonto_for_all_contracts(self):
         return akonto_total
 
 
+# TODO: This is now done directly in report/nk/bill.py => Remove together with legacy code in report/nk_report.py
 class QRBill(APIView):
     """
     Create and return QRBill and execute corresponding accounting transactions.

django/geno/models.py

@@ -734,6 +734,23 @@ class Building(GenoBase):
     egid = models.PositiveIntegerField("EGID", null=True, blank=True)
     active = models.BooleanField("Aktiv", default=True)
 
+    @property
+    def full_name(self):
+        ret = self.name
+        if self.street_name and self.house_number:
+            address = "%s %s" % (self.street_name, self.house_number)
+        else:
+            address = self.street_name
+        if address and address != self.name:
+            ret += ", %s" % address
+        if self.city_zipcode and self.city_name:
+            ret += ", %s %s" % (self.city_zipcode, self.city_name)
+        elif self.city_name:
+            ret += ", %s" % self.city_name
+        if self.country and self.country != get_default_country_code():
+            ret += ", %s" % self.get_country_display()
+        return ret
+
     class Meta:
         ordering = ["name"]
         verbose_name = "Liegenschaft"

django/geno/tests/data.py

@@ -555,7 +555,16 @@ def create_registrationevents(cls):
 
 def create_buildings(cls, count=2):
     cls.buildings = []
-    for i in range(count):
+    cls.buildings.append(
+        Building.objects.create(
+            name="Musterweg 1",
+            street_name="Musterweg",
+            house_number="1",
+            city_zipcode="3000",
+            city_name="Bern",
+        )
+    )
+    for i in range(2, count):
         cls.buildings.append(Building.objects.create(name=f"Musterweg {i + 1}"))