Skip to content

Prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers (chains.tekton.dev) #1218

Open
@jsoref

Description

@jsoref

https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_chains/1148/pull-tekton-chains-integration-tests/1807738097719316480/

    {"level":"warn","ts":"2024-07-01T11:51:34.769Z","logger":"watcher","caller":"logging/warning_handler.go:32","msg":"API Warning: metadata.finalizers: \"chains.tekton.dev\": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers","commit":"2f98765-dirty"}

FinalizerName: "chains.tekton.dev",

The theoretical fix for this is:

- FinalizerName:     "chains.tekton.dev", 
+ FinalizerName:     "chains.tekton.dev/finalizer", 

But, in practice, if your objects are long lived, you will want to include migration code so that old finalizer values are accepted/handled.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions