Skip to content

CI: Use goinstall mode for golangci-lint action#2984

Open
vdemeester wants to merge 1 commit into
tektoncd:mainfrom
vdemeester:fix/golangci-lint-goinstall
Open

CI: Use goinstall mode for golangci-lint action#2984
vdemeester wants to merge 1 commit into
tektoncd:mainfrom
vdemeester:fix/golangci-lint-goinstall

Conversation

@vdemeester

Copy link
Copy Markdown
Member

Changes

The prebuilt golangci-lint binary (v2.7.2) was built with Go 1.25, which is incompatible with our Go 1.26 toolchain. This caused lint failures on all main branch PRs with:

Error: can't load config: the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26.x)

This PR:

  • Switches to install-mode: goinstall so golangci-lint is compiled from source using the project's Go version, avoiding the mismatch
  • Bumps the action from v9.2.0 to v9.2.1
  • Bumps golangci-lint from v2.7.2 to v2.12.2

This matches what tektoncd/pipeline already does.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

NONE

The prebuilt golangci-lint binary (v2.7.2) was built with Go 1.25,
which is incompatible with our Go 1.26 toolchain. This caused lint
failures on all main branch PRs with:

  Error: can't load config: the Go language version (go1.25) used to
  build golangci-lint is lower than the targeted Go version (1.26.x)

Switch to install-mode: goinstall so golangci-lint is compiled from
source using the project's Go version, avoiding the mismatch. Also
bump the action to v9.2.1 and golangci-lint to v2.12.2, matching
tektoncd/pipeline.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 3, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants