Skip to content

Commit d825779

Browse files
AlanGreenetekton-robot
authored andcommitted
Update E2E base image workflow to specify default value on input
Instead of defaulting the value when declaring the env var, do it in the input. This means the value is displayed to the user before they proceed and can be modified or overridden in the GitHub Actions UI more easily if needed.
1 parent 35bde4b commit d825779

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/e2e-base-image.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ on:
77
workflow_dispatch:
88
inputs:
99
tag:
10-
description: 'Tag containing the Node.js and browser versions, e.g. node24.14.0-chrome140'
11-
required: false
10+
description: 'Image tag, typically containing the Node.js and browser versions'
11+
required: true
12+
default: 'node24.14.0-chrome147'
13+
type: string
1214

1315
concurrency:
1416
group: ${{ github.workflow }}
@@ -20,7 +22,7 @@ defaults:
2022

2123
env:
2224
REGISTRY: ghcr.io
23-
TAG: ${{ inputs.tag || 'node24.14.0-chrome147' }}
25+
TAG: ${{ inputs.tag }}
2426

2527
jobs:
2628
build:

packages/e2e/base-image/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
To create a release:
66

77
- verify the `CHROME_VERSION` and `NODE_VERSION` args in the [`Dockerfile`](./Dockerfile) on the main branch are correct
8-
- set a matching tag value in the `TAG` environment variable in the [workflow](../../../.github/workflows/e2e-base-image.yml), e.g. `node20.11.0-chrome121`
8+
- set a matching tag value for the `on.workflow_dispatch.inputs.tag.default` input in the [workflow](../../../.github/workflows/e2e-base-image.yml), e.g. `node20.11.0-chrome121`
99
- manually trigger the [workflow](https://github.com/tektoncd/dashboard/actions/workflows/e2e-base-image.yml)
1010
- check the status of the resulting run
1111
- confirm the image was [released and properly tagged](https://github.com/tektoncd/dashboard/pkgs/container/dashboard%2Fdashboard-e2e-base)

0 commit comments

Comments
 (0)