|
| 1 | +//go:build e2e |
| 2 | +// +build e2e |
| 3 | + |
| 4 | +/* |
| 5 | +Copyright 2026 The Tekton Authors |
| 6 | +
|
| 7 | +Licensed under the Apache License, Version 2.0 (the "License"); |
| 8 | +you may not use this file except in compliance with the License. |
| 9 | +You may obtain a copy of the License at |
| 10 | +
|
| 11 | + http://www.apache.org/licenses/LICENSE-2.0 |
| 12 | +
|
| 13 | +Unless required by applicable law or agreed to in writing, software |
| 14 | +distributed under the License is distributed on an "AS IS" BASIS, |
| 15 | +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 16 | +See the License for the specific language governing permissions and |
| 17 | +limitations under the License. |
| 18 | +*/ |
| 19 | + |
| 20 | +package common |
| 21 | + |
| 22 | +import ( |
| 23 | + "bytes" |
| 24 | + "context" |
| 25 | + "fmt" |
| 26 | + "os/exec" |
| 27 | + "path/filepath" |
| 28 | + "runtime" |
| 29 | + "testing" |
| 30 | + |
| 31 | + "github.com/tektoncd/operator/test/client" |
| 32 | + "github.com/tektoncd/operator/test/resources" |
| 33 | + "github.com/tektoncd/operator/test/utils" |
| 34 | + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 35 | +) |
| 36 | + |
| 37 | +const ( |
| 38 | + npTestNamespace = "tekton-np-e2e" |
| 39 | + npEventListenerName = "np-test-listener" |
| 40 | +) |
| 41 | + |
| 42 | +// TestTektonTriggerNetworkPolicy verifies NetworkPolicies are created by default, |
| 43 | +// that Triggers resources work correctly under those policies (EventListener |
| 44 | +// receives events and creates PipelineRuns), and that toggling |
| 45 | +// spec.networkPolicy.disabled correctly adds and removes the policies. |
| 46 | +func TestTektonTriggerNetworkPolicy(t *testing.T) { |
| 47 | + crNames := utils.GetResourceNames() |
| 48 | + clients := client.Setup(t, crNames.TargetNamespace) |
| 49 | + |
| 50 | + utils.CleanupOnInterrupt(func() { utils.TearDownPipeline(clients, crNames.TektonPipeline) }) |
| 51 | + utils.CleanupOnInterrupt(func() { utils.TearDownTrigger(clients, crNames.TektonTrigger) }) |
| 52 | + utils.CleanupOnInterrupt(func() { utils.TearDownNamespace(clients, npTestNamespace) }) |
| 53 | + utils.CleanupOnInterrupt(func() { deleteNPTestClusterRoleBinding(t) }) |
| 54 | + defer utils.TearDownNamespace(clients, npTestNamespace) |
| 55 | + defer deleteNPTestClusterRoleBinding(t) |
| 56 | + defer utils.TearDownPipeline(clients, crNames.TektonPipeline) |
| 57 | + defer utils.TearDownTrigger(clients, crNames.TektonTrigger) |
| 58 | + |
| 59 | + resources.EnsureNoTektonConfigInstance(t, clients, crNames) |
| 60 | + |
| 61 | + if _, err := resources.EnsureTektonPipelineExists(clients.TektonPipeline(), crNames); err != nil { |
| 62 | + t.Fatalf("TektonPipeline %q failed to create: %v", crNames.TektonPipeline, err) |
| 63 | + } |
| 64 | + resources.AssertTektonPipelineCRReadyStatus(t, clients, crNames) |
| 65 | + |
| 66 | + if _, err := resources.EnsureTektonTriggerExists(clients.TektonTrigger(), crNames); err != nil { |
| 67 | + t.Fatalf("TektonTrigger %q failed to create: %v", crNames.TektonTrigger, err) |
| 68 | + } |
| 69 | + resources.AssertTektonTriggerCRReadyStatus(t, clients, crNames) |
| 70 | + |
| 71 | + expectedPolicies := []string{ |
| 72 | + "tekton-default-deny", |
| 73 | + "triggers-controller", |
| 74 | + "triggers-webhook", |
| 75 | + "triggers-core-interceptors", |
| 76 | + } |
| 77 | + |
| 78 | + t.Run("default-policies-created", func(t *testing.T) { |
| 79 | + resources.AssertNetworkPoliciesExist(t, clients, crNames.TargetNamespace, expectedPolicies) |
| 80 | + }) |
| 81 | + |
| 82 | + t.Run("triggers-functional-with-networkpolicies", func(t *testing.T) { |
| 83 | + if err := resources.CreateNamespace(clients.KubeClient, npTestNamespace); err != nil { |
| 84 | + t.Fatalf("failed to create test namespace %q: %v", npTestNamespace, err) |
| 85 | + } |
| 86 | + if err := applyTriggersTestdata(t, npTestNamespace); err != nil { |
| 87 | + t.Fatalf("failed to apply Triggers testdata: %v", err) |
| 88 | + } |
| 89 | + |
| 90 | + // EventListener Ready proves controller reached the API server. |
| 91 | + resources.AssertEventListenerReady(t, clients, npTestNamespace, npEventListenerName) |
| 92 | + |
| 93 | + // action=push matches the CEL filter; exercises interceptors ingress + API server egress. |
| 94 | + t.Run("cel-interceptor-matching-event-creates-pipelinerun", func(t *testing.T) { |
| 95 | + if err := sendEventToListener(t, npTestNamespace, npEventListenerName, `{"action":"push"}`); err != nil { |
| 96 | + t.Fatalf("matching event failed: %v", err) |
| 97 | + } |
| 98 | + resources.AssertPipelineRunCreated(t, clients, npTestNamespace) |
| 99 | + }) |
| 100 | + |
| 101 | + // action=open does not match; interceptor blocks it, no new PipelineRun. |
| 102 | + t.Run("cel-interceptor-non-matching-event-blocked", func(t *testing.T) { |
| 103 | + prsBefore, err := clients.TektonClient.PipelineRuns(npTestNamespace).List(context.TODO(), metav1.ListOptions{}) |
| 104 | + if err != nil { |
| 105 | + t.Fatalf("failed to list PipelineRuns: %v", err) |
| 106 | + } |
| 107 | + _ = sendEventToListener(t, npTestNamespace, npEventListenerName, `{"action":"open"}`) |
| 108 | + resources.AssertPipelineRunCountUnchanged(t, clients, npTestNamespace, len(prsBefore.Items)) |
| 109 | + }) |
| 110 | + }) |
| 111 | + |
| 112 | + t.Run("disable-removes-policies", func(t *testing.T) { |
| 113 | + tt, err := clients.TektonTrigger().Get(context.TODO(), crNames.TektonTrigger, metav1.GetOptions{}) |
| 114 | + if err != nil { |
| 115 | + t.Fatalf("failed to get TektonTrigger: %v", err) |
| 116 | + } |
| 117 | + tt.Spec.NetworkPolicy.Disabled = true |
| 118 | + if _, err := clients.TektonTrigger().Update(context.TODO(), tt, metav1.UpdateOptions{}); err != nil { |
| 119 | + t.Fatalf("failed to disable NetworkPolicy on TektonTrigger: %v", err) |
| 120 | + } |
| 121 | + resources.AssertTektonTriggerCRReadyStatus(t, clients, crNames) |
| 122 | + resources.AssertNetworkPoliciesAbsent(t, clients, crNames.TargetNamespace, expectedPolicies) |
| 123 | + }) |
| 124 | + |
| 125 | + t.Run("reenable-restores-policies", func(t *testing.T) { |
| 126 | + tt, err := clients.TektonTrigger().Get(context.TODO(), crNames.TektonTrigger, metav1.GetOptions{}) |
| 127 | + if err != nil { |
| 128 | + t.Fatalf("failed to get TektonTrigger: %v", err) |
| 129 | + } |
| 130 | + tt.Spec.NetworkPolicy.Disabled = false |
| 131 | + if _, err := clients.TektonTrigger().Update(context.TODO(), tt, metav1.UpdateOptions{}); err != nil { |
| 132 | + t.Fatalf("failed to re-enable NetworkPolicy on TektonTrigger: %v", err) |
| 133 | + } |
| 134 | + resources.AssertTektonTriggerCRReadyStatus(t, clients, crNames) |
| 135 | + resources.AssertNetworkPoliciesExist(t, clients, crNames.TargetNamespace, expectedPolicies) |
| 136 | + }) |
| 137 | +} |
| 138 | + |
| 139 | +// deleteNPTestClusterRoleBinding removes the cluster-scoped binding created by rbac.yaml. |
| 140 | +func deleteNPTestClusterRoleBinding(t *testing.T) { |
| 141 | + t.Helper() |
| 142 | + cmd := exec.Command("kubectl", "delete", "clusterrolebinding", "np-test-el-clusterrolebinding", "--ignore-not-found") |
| 143 | + _ = cmd.Run() |
| 144 | +} |
| 145 | + |
| 146 | +// applyTriggersTestdata applies testdata/triggers/ YAML into namespace. |
| 147 | +func applyTriggersTestdata(t *testing.T, namespace string) error { |
| 148 | + t.Helper() |
| 149 | + _, file, _, ok := runtime.Caller(0) |
| 150 | + if !ok { |
| 151 | + return fmt.Errorf("failed to get caller information") |
| 152 | + } |
| 153 | + testdataDir := filepath.Join(filepath.Dir(file), "testdata", "triggers") |
| 154 | + |
| 155 | + var stderr bytes.Buffer |
| 156 | + cmd := exec.Command("kubectl", "apply", "-f", testdataDir, "-n", namespace) |
| 157 | + cmd.Stderr = &stderr |
| 158 | + if err := cmd.Run(); err != nil { |
| 159 | + return fmt.Errorf("kubectl apply failed: %v\n%s", err, stderr.String()) |
| 160 | + } |
| 161 | + return nil |
| 162 | +} |
| 163 | + |
| 164 | +// sendEventToListener POSTs payload to the EventListener from a temporary in-cluster pod. |
| 165 | +func sendEventToListener(t *testing.T, namespace, listenerName, payload string) error { |
| 166 | + t.Helper() |
| 167 | + svcURL := fmt.Sprintf("http://el-%s.%s.svc.cluster.local:8080", listenerName, namespace) |
| 168 | + |
| 169 | + var stderr bytes.Buffer |
| 170 | + cmd := exec.Command( |
| 171 | + "kubectl", "run", "np-e2e-curl", "--restart=Never", "--rm", "-i", |
| 172 | + "--image=curlimages/curl:latest", |
| 173 | + "-n", namespace, |
| 174 | + "--", |
| 175 | + "curl", "-s", "-o", "/dev/null", "-w", "%{http_code}", |
| 176 | + "-X", "POST", svcURL, |
| 177 | + "-H", "Content-Type: application/json", |
| 178 | + "-d", payload, |
| 179 | + ) |
| 180 | + cmd.Stderr = &stderr |
| 181 | + out, err := cmd.Output() |
| 182 | + if err != nil { |
| 183 | + return fmt.Errorf("curl pod failed: %v\nstderr: %s", err, stderr.String()) |
| 184 | + } |
| 185 | + // kubectl --rm appends the pod deletion message to stdout; take only the first |
| 186 | + // 3 bytes which are the curl %{http_code} output. |
| 187 | + raw := string(bytes.TrimSpace(out)) |
| 188 | + if len(raw) < 3 || (raw[:3] != "200" && raw[:3] != "202") { |
| 189 | + return fmt.Errorf("EventListener returned unexpected HTTP status %q (want 200/202)", raw) |
| 190 | + } |
| 191 | + return nil |
| 192 | +} |
0 commit comments