chore: return early from detect for edited comments

when edited comment event is recieved, we used to
return in ParsePayload which is quite late because
we don't wanna entertain that event for issue_comment
and commit_comment so this commit makes it return
early in detect func.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

Author: zakisk

pkg/provider/github/detect.go

@@ -76,8 +76,11 @@ func (v *Provider) detectTriggerTypeFromPayload(ghEventType string, eventInt any
 		}
 		return "", fmt.Sprintf("pull_request: unsupported action \"%s\"", event.GetAction())
 	case *github.IssueCommentEvent:
-		if event.GetAction() == "created" &&
-			event.GetIssue().IsPullRequest() &&
+		if event.GetAction() != "created" {
+			return "", fmt.Sprintf("issue_comment: unsupported action \"%s\"", event.GetAction())
+		}
+
+		if event.GetIssue().IsPullRequest() &&
 			event.GetIssue().GetState() == "open" {
 			if opscomments.IsTestRetestComment(event.GetComment().GetBody(), gitOpsCommentPrefix) {
 				return triggertype.Retest, ""
@@ -101,18 +104,20 @@ func (v *Provider) detectTriggerTypeFromPayload(ghEventType string, eventInt any
 		}
 		return "", fmt.Sprintf("check_run: unsupported action \"%s\"", event.GetAction())
 	case *github.CommitCommentEvent:
-		if event.GetAction() == "created" {
-			if opscomments.IsTestRetestComment(event.GetComment().GetBody(), gitOpsCommentPrefix) {
-				return triggertype.Retest, ""
-			}
-			if opscomments.IsCancelComment(event.GetComment().GetBody(), gitOpsCommentPrefix) {
-				return triggertype.Cancel, ""
-			}
-			// Here, the `/ok-to-test` command is ignored because it is intended for pull requests.
-			// For unauthorized users, it has no relevance to pushed commits, as only authorized users
-			// are allowed to run CI on pushed commits. Therefore, the `ok-to-test` command holds no significance in this context.
-			// However, it is left to be processed by the `on-comment` annotation rather than returning an error.
+		if event.GetAction() != "created" {
+			return "", fmt.Sprintf("commit_comment: unsupported action \"%s\"", event.GetAction())
+		}
+
+		if opscomments.IsTestRetestComment(event.GetComment().GetBody(), gitOpsCommentPrefix) {
+			return triggertype.Retest, ""
+		}
+		if opscomments.IsCancelComment(event.GetComment().GetBody(), gitOpsCommentPrefix) {
+			return triggertype.Cancel, ""
 		}
+		// Here, the `/ok-to-test` command is ignored because it is intended for pull requests.
+		// For unauthorized users, it has no relevance to pushed commits, as only authorized users
+		// are allowed to run CI on pushed commits. Therefore, the `ok-to-test` command holds no significance in this context.
+		// However, it is left to be processed by the `on-comment` annotation rather than returning an error.
 		return triggertype.Comment, ""
 	}
 	return "", fmt.Sprintf("github: event \"%v\" is not supported", ghEventType)

pkg/provider/github/detect_test.go

@@ -74,9 +74,10 @@ func TestProviderDetect(t *testing.T) {
 			event: github.CommitCommentEvent{
 				Action: github.Ptr("something"),
 			},
+			wantReason: "commit_comment: unsupported action \"something\"",
 			eventType:  "commit_comment",
 			isGH:       true,
-			processReq: true,
+			processReq: false,
 		},
 		{
 			name: "invalid check run Event",
@@ -92,9 +93,10 @@ func TestProviderDetect(t *testing.T) {
 			event: github.IssueCommentEvent{
 				Action: github.Ptr("deleted"),
 			},
+			wantReason: "issue_comment: unsupported action \"deleted\"",
 			eventType:  "issue_comment",
 			isGH:       true,
-			processReq: true,
+			processReq: false,
 		},
 		{
 			name: "issue comment Event with no valid comment",

pkg/provider/github/parse_payload.go

@@ -353,9 +353,6 @@ func (v *Provider) processEvent(ctx context.Context, event *info.Event, eventInt
 			return nil, fmt.Errorf("no github client has been initialized, " +
 				"exiting... (hint: did you forget setting a secret on your repo?)")
 		}
-		if gitEvent.GetAction() != "created" {
-			return nil, fmt.Errorf("only newly created comment is supported, received: %s", gitEvent.GetAction())
-		}
 		processedEvent, err = v.handleIssueCommentEvent(ctx, gitEvent)
 		if err != nil {
 			return nil, err

pkg/provider/github/parse_payload_test.go

@@ -744,14 +744,6 @@ func TestParsePayLoad(t *testing.T) {
 				},
 			},
 		},
-		{
-			name:               "bad/issue_comment_not_from_created",
-			wantErrString:      "only newly created comment is supported, received: deleted",
-			payloadEventStruct: github.IssueCommentEvent{Action: github.Ptr("deleted")},
-			eventType:          "issue_comment",
-			triggerTarget:      "pull_request",
-			githubClient:       true,
-		},
 		{
 			name:          "good/issue comment",
 			eventType:     "issue_comment",