Skip to content

Commit a66cb1d

Browse files
authored
Merge pull request #866 from tekton-robot/cherry-pick-857-to-release-v0.12.x
[release-v0.12.x] Add Debug Logs for Third Party Logging API
2 parents ab8f466 + 1cf6b42 commit a66cb1d

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

pkg/api/server/v1alpha2/plugin_logs.go

+23
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"fmt"
77
"io"
88
"net/http"
9+
"net/http/httputil"
910
"net/url"
1011
"path"
1112
"strconv"
@@ -168,12 +169,34 @@ func (s *LogPluginServer) getLokiLogs(writer *logs.BufferedLog, parent string, r
168169
req.Header.Set("Authorization", "Bearer "+token.AccessToken)
169170
resp, err := s.client.Do(req)
170171
if err != nil {
172+
dump, err := httputil.DumpRequest(req, true)
173+
if err == nil {
174+
s.logger.Debugf("Request Dump***:\n %q\n", dump)
175+
}
171176
s.logger.Errorf("request to loki failed, err: %s, req: %v", err.Error(), req)
172177
return status.Error(codes.Internal, "Error streaming log")
173178
}
174179

180+
if resp == nil {
181+
dump, err := httputil.DumpRequest(req, true)
182+
if err == nil {
183+
s.logger.Debugf("Request Dump***:\n %q\n", dump)
184+
}
185+
s.logger.Errorf("request to loki failed, received nil response")
186+
s.logger.Debugf("loki request url:%s", URL.String())
187+
return status.Error(codes.Internal, "Error streaming log")
188+
}
189+
175190
if resp.StatusCode != http.StatusOK {
176191
s.logger.Errorf("Loki API request failed with HTTP status code: %d", resp.StatusCode)
192+
dump, err := httputil.DumpRequest(req, true)
193+
if err == nil {
194+
s.logger.Debugf("Request Dump***:\n %q\n", dump)
195+
}
196+
dump, err = httputil.DumpResponse(resp, true)
197+
if err == nil {
198+
s.logger.Debugf("Response Dump***:\n %q\n", dump)
199+
}
177200
return status.Error(codes.Internal, "Error fetching log data")
178201
}
179202

0 commit comments

Comments
 (0)