fix(hooks): openclaw --with-hooks was a silent no-op

install-hooks.sh's openclaw branch only echoed manual copy instructions and
never touched disk, while every other platform (claude/codex/gemini/pi/hermes)
actually performs the install. bin/install.js's maybeSpawnInstallHooks() only
checks the script's exit code, so this printed "hook 已注入 openclaw" even
though nothing was installed — and per its own comment, code-abyss is the
*only* entry point for openclaw hook injection (abyss CLI deliberately
doesn't handle it), so this meant openclaw users following --with-hooks got
nothing, silently.

The printed manual instruction was also itself broken: `cp .../plugin.js
~/.openclaw/plugins/abyss-hooks.js` flattens the file, but plugin.js resolves
its hook scripts via path.join(__dirname, '..', 'common') — it needs an
`openclaw/` dir with a sibling `common/`, not a loose file. Fixed by mirroring
hermes's own pattern (an actual `cp` into a self-contained plugin directory)
while preserving that directory relationship, so the copied plugin.js's
relative lookup still resolves.

Added test/install-hooks-sh.test.js — this script had zero test coverage
before, which is how a no-op-reported-as-success bug went unnoticed.

Co-authored-by: telagod <telagod@users.noreply.github.com>

Author: telagod

skills/indexing-code/hooks/common/install-hooks.sh

@@ -138,9 +138,17 @@ YAML
     ;;
 
   openclaw)
-    echo "OpenClaw: copy the plugin file to your OpenClaw plugins directory:"
-    echo "  cp ${HOOK_ROOT}/openclaw/plugin.js ~/.openclaw/plugins/abyss-hooks.js"
-    echo "  Then register in your plugin config."
+    # plugin.js resolves its hook scripts via path.join(__dirname, '..', 'common') —
+    # it needs an `openclaw/` dir with a sibling `common/` wherever it lands, so a
+    # flat single-file copy (the old behavior here — and the old printed instruction,
+    # which told users to do the same broken copy manually) silently breaks that
+    # lookup. Mirror the source hooks/ layout instead.
+    PLUGIN_DIR="${HOME}/.openclaw/plugins/abyss-hooks"
+    mkdir -p "$PLUGIN_DIR/openclaw"
+    cp -r "${HOOK_ROOT}/common" "$PLUGIN_DIR/common"
+    cp "${HOOK_ROOT}/openclaw/plugin.js" "$PLUGIN_DIR/openclaw/plugin.js"
+    echo "✓ OpenClaw plugin installed at $PLUGIN_DIR/openclaw/plugin.js"
+    echo "  Register it in your OpenClaw plugin config to enable it."
     ;;
 
   *)

test/install-hooks-sh.test.js

@@ -0,0 +1,52 @@
+'use strict';
+
+const path = require('path');
+const fs = require('fs');
+const os = require('os');
+const { spawnSync } = require('child_process');
+
+const SCRIPT = path.join(__dirname, '..', 'skills', 'indexing-code', 'hooks', 'common', 'install-hooks.sh');
+
+describe('install-hooks.sh openclaw branch', () => {
+  let tmpHome;
+
+  beforeEach(() => {
+    tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), 'code-abyss-hooks-test-'));
+  });
+
+  afterEach(() => {
+    fs.rmSync(tmpHome, { recursive: true, force: true });
+  });
+
+  test('actually installs the plugin (not just prints instructions)', () => {
+    const r = spawnSync('bash', [SCRIPT, 'openclaw'], {
+      env: { ...process.env, HOME: tmpHome },
+      encoding: 'utf8',
+    });
+    expect(r.status).toBe(0);
+
+    const pluginDir = path.join(tmpHome, '.openclaw', 'plugins', 'abyss-hooks');
+    expect(fs.existsSync(path.join(pluginDir, 'openclaw', 'plugin.js'))).toBe(true);
+    expect(fs.existsSync(path.join(pluginDir, 'common', 'session-init.sh'))).toBe(true);
+    expect(fs.existsSync(path.join(pluginDir, 'common', 'pre-edit-check.sh'))).toBe(true);
+  });
+
+  test('installed plugin.js resolves its hook scripts via the correct relative path (does not silently break on copy)', () => {
+    spawnSync('bash', [SCRIPT, 'openclaw'], { env: { ...process.env, HOME: tmpHome } });
+
+    const pluginPath = path.join(tmpHome, '.openclaw', 'plugins', 'abyss-hooks', 'openclaw', 'plugin.js');
+    const hookDir = path.join(path.dirname(pluginPath), '..', 'common');
+    expect(fs.existsSync(path.join(hookDir, 'session-init.sh'))).toBe(true);
+    expect(fs.existsSync(path.join(hookDir, 'pre-edit-check.sh'))).toBe(true);
+
+    const register = require(pluginPath);
+    expect(typeof register).toBe('function');
+  });
+
+  test('idempotent: running twice does not fail', () => {
+    const first = spawnSync('bash', [SCRIPT, 'openclaw'], { env: { ...process.env, HOME: tmpHome } });
+    const second = spawnSync('bash', [SCRIPT, 'openclaw'], { env: { ...process.env, HOME: tmpHome } });
+    expect(first.status).toBe(0);
+    expect(second.status).toBe(0);
+  });
+});