Linting

Author: jason-fox

lib/commonConfig.js

@@ -516,7 +516,7 @@ function getConfig() {
 function getConfigForTypeInformation() {
     // Just return relevant configuration flags
     // avoid to include server, authentication, mongodb, orion and iotamanger info
-    let conf = {
+    const conf = {
         timestamp: config.timestamp,
         defaultResource: config.defaultResource,
         explicitAttrs: config.explicitAttrs,

lib/services/ngsi/entities-NGSI-LD.js

@@ -65,6 +65,7 @@ function convertAttrNGSILD(attr) {
         // Properties
         case 'property':
             hasValueType = false;
+            break;
         case 'string':
         case 'text':
         case 'textunrestricted':
@@ -102,7 +103,9 @@ function convertAttrNGSILD(attr) {
         case 'array':
             try {
                 obj.value = JSON.parse(attr.value);
-            } catch (e) {}
+            } catch (e) {
+                // Do nothing
+            }
             break;
 
         // Temporal Properties
@@ -179,21 +182,21 @@ function convertAttrNGSILD(attr) {
             obj.vocab = attr.value;
             delete obj.value;
             break;
-        // VocabProperties
+        // JsonProperties
         case 'jsonproperty':
             hasValueType = false;
             obj.type = 'JsonProperty';
             obj.json = attr.value;
             delete obj.value;
             break;
-        // VocabProperties
+        // ListProperties
         case 'listproperty':
             hasValueType = false;
             obj.type = 'ListProperty';
             obj.listValue = attr.value;
             delete obj.value;
             break;
-        // VocabProperties
+        // ListRelationship
         case 'listrelationship':
             hasValueType = false;
             obj.type = 'ListRelationship';

test/unit/ngsi-ld/ngsiService/value-types-test.js

@@ -28,9 +28,7 @@
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
 const should = require('should');
-const logger = require('logops');
 const nock = require('nock');
-const timekeeper = require('timekeeper');
 let contextBrokerMock;
 const iotAgentConfig = {
     logLevel: 'FATAL',