try to fix the verify tasks

Author: xFuture603

roles/icinga_agent/molecule/default/converge.yml

@@ -98,64 +98,109 @@
         state: file
       register: result_icinga2_conf
 
-    - name: validate icinga2.conf results
+    - name: validate icinga2.conf results for RedHat based Distributions
       assert:
         that:
           - "result_icinga2_conf.state == 'file'"
           - "result_icinga2_conf.mode == '0640'"
           - "result_icinga2_conf.owner == 'icinga'"
           - "result_icinga2_conf.group == 'icinga'"
+      when: ansible_os_family == 'RedHat'
+
+    - name: validate icinga2.conf results for Debian based Distributions
+      assert:
+        that:
+          - "result_icinga2_conf.state == 'file'"
+          - "result_icinga2_conf.mode == '0640'"
+          - "result_icinga2_conf.owner == 'nagios'"
+          - "result_icinga2_conf.group == 'nagios'"
+      when: ansible_os_family == 'Debian'
 
     - name: verify that constants.conf exists
       file:
         path: /etc/icinga2/constants.conf
         state: file
       register: result_constants_conf
 
-    - name: validate constants.conf results
+    - name: validate constants.conf results for RedHat based Distributions
       assert:
         that:
           - "result_constants_conf.state == 'file'"
           - "result_constants_conf.mode == '0640'"
           - "result_constants_conf.owner == 'icinga'"
           - "result_constants_conf.group == 'icinga'"
+      when: ansible_os_family == 'RedHat'
+
+    - name: validate constants.conf results for Debian based Distributions
+      assert:
+        that:
+          - "result_constants_conf.state == 'file'"
+          - "result_constants_conf.mode == '0640'"
+          - "result_constants_conf.owner == 'nagios'"
+          - "result_constants_conf.group == 'nagios'"
+      when: ansible_os_family == 'Debian'
 
     - name: verify that zones.conf exists
       file:
         path: /etc/icinga2/zones.conf
         state: file
       register: result_zones_conf
 
-    - name: validate zones.conf results
+    - name: validate zones.conf results for RedHat based Distributions
       assert:
         that:
           - "result_zones_conf.state == 'file'"
           - "result_zones_conf.mode == '0640'"
           - "result_zones_conf.owner == 'icinga'"
           - "result_zones_conf.group == 'icinga'"
+      when: ansible_os_family == 'RedHat'
+
+    - name: validate zones.conf results for Debian based Distributions
+      assert:
+        that:
+          - "result_zones_conf.state == 'file'"
+          - "result_zones_conf.mode == '0640'"
+          - "result_zones_conf.owner == 'nagios'"
+          - "result_zones_conf.group == 'nagios'"
+      when: ansible_os_family == 'Debian'
 
     - name: verify that api.conf exists
       file:
         path: /etc/icinga2/features-available/api.conf
         state: file
       register: result_api_conf
 
-    - name: validate api.conf results
+    - name: validate api.conf results for RedHat based Distributions
       assert:
         that:
           - "result_api_conf.state == 'file'"
           - "result_api_conf.mode == '0640'"
           - "result_api_conf.owner == 'icinga'"
           - "result_api_conf.group == 'icinga'"
-
-    - name: verify that icinga2 package is installed
-      yum:
-        name: icinga2
-        state: present
       when: ansible_os_family == 'RedHat'
 
-    - name: verify that icinga2 package is installed for Debian based systems
-      apt:
+    - name: validate api.conf results for Debian based Distributions
+      assert:
+        that:
+          - "result_api_conf.state == 'file'"
+          - "result_api_conf.mode == '0640'"
+          - "result_api_conf.owner == 'nagios'"
+          - "result_api_conf.group == 'nagios'"
+      when: ansible_os_family == 'Debian'
+
+    # - name: verify that icinga2 package is installed
+    #   yum:
+    #     name: icinga2
+    #     state: present
+    #   when: ansible_os_family == 'RedHat'
+
+    # - name: verify that icinga2 package is installed for Debian based systems
+    #   apt:
+    #     name: icinga2
+    #     state: present
+    #   when: ansible_os_family == 'Debian'
+
+    - name: verify that icinga2 package is installed
+      ansible.builtin.package:
         name: icinga2
         state: present
-      when: ansible_os_family == 'Debian'

roles/icinga_agent/tasks/main.yml

@@ -9,8 +9,8 @@
 - name: create /etc/icinga2/repository.d
   ansible.builtin.file:
     dest: "/etc/icinga2/repository.d"
-    owner: "{{icinga2_user[ansible_os_family]}}"
-    group: "{{icinga2_group[ansible_os_family]}}"
+    owner: "{{ icinga2_user[ansible_os_family] }}"
+    group: "{{ icinga2_group[ansible_os_family] }}"
     state: directory
   when:
     - icinga_agent_repositoryd_directory is defined
@@ -19,8 +19,8 @@
   ansible.builtin.template:
     src: "{{ item }}"
     dest: "/etc/icinga2/{{ item | basename | regex_replace('.j2', '') }}"
-    owner: "{{icinga2_user[ansible_os_family]}}"
-    group: "{{icinga2_group[ansible_os_family]}}"
+    owner: "{{ icinga2_user[ansible_os_family] }}"
+    group: "{{ icinga2_group[ansible_os_family] }}"
     mode: 0640
   with_fileglob:
     - "../templates/configuration/*"
@@ -31,8 +31,8 @@
   ansible.builtin.template:
     src: "{{ item }}"
     dest: "/etc/icinga2/features-available/{{ item | basename | regex_replace('.j2', '') }}"
-    owner: "{{icinga2_user[ansible_os_family]}}"
-    group: "{{icinga2_group[ansible_os_family]}}"
+    owner: "{{ icinga2_user[ansible_os_family] }}"
+    group: "{{ icinga2_group[ansible_os_family] }}"
     mode: 0640
   with_fileglob:
     - "../templates/features/*"
@@ -43,8 +43,8 @@
   ansible.builtin.template:
     src: "{{ item }}"
     dest: "/etc/icinga2/features-available/{{ item | basename | regex_replace('.j2', '') }}"
-    owner: "{{icinga2_user[ansible_os_family]}}"
-    group: "{{icinga2_group[ansible_os_family]}}"
+    owner: "{{ icinga2_user[ansible_os_family] }}"
+    group: "{{ icinga2_group[ansible_os_family] }}"
     mode: 0640
   with_fileglob:
     - "{{ icinga_agent_custom_features_template_path }}"