Added method placeholders in method comparison

Author: martingrossmann

report-ng/app/src/components/history/run-comparison/method-table.html

@@ -66,6 +66,7 @@
                     ></a>
                     <a if.bind="!methodHistory.methodRunId && !methodHistory.methodHistoryAvailable"
                        innerhtml.bind="methodHistory.methodIdentifier"></a>
+                    <div if.bind="!methodHistory.currentStatus">(${methodHistory.methodIdentifier})</div>
                     <div
                         if.bind="methodHistory.changedFailureAspect && methodHistory.pastStatus === methodHistory.currentStatus"
                         class="st1"

report-ng/app/src/components/history/run-comparison/method-table.ts

@@ -24,6 +24,7 @@ import {bindable} from "aurelia-templating";
 import {bindingMode} from "aurelia-binding";
 import "./method-table.scss";
 import {IComparableMethod} from "./run-comparison";
+import {ClassName, ClassNameValueConverter} from "../../../value-converters/class-name-value-converter";
 
 @autoinject()
 export class MethodTable {
@@ -37,4 +38,18 @@ export class MethodTable {
 
     constructor() {
     }
+
+    methodsChanged() {
+        if (this.methods) {
+            let converter = new ClassNameValueConverter();
+            this.methods = this.methods.sort((a, b) => {
+                const aClass = converter.toView(a.classIdentifier, ClassName.simpleName);
+                const bClass = converter.toView(b.classIdentifier, ClassName.simpleName);
+                if (aClass < bClass) return -1;
+                if (aClass > bClass) return 1;
+                return 0;
+            });
+        }
+
+    }
 }

report-ng/app/src/components/history/run-comparison/run-comparison.ts

@@ -36,6 +36,12 @@ export interface IComparableMethod {
     methodHistoryAvailable: boolean
 }
 
+interface IRunToCompare {
+    historyIndex: number,
+    startTime: number
+}
+
+
 @autoinject()
 export class RunComparison extends AbstractViewModel {
     private _historyStatistics: HistoryStatistics;
@@ -147,7 +153,3 @@ export class RunComparison extends AbstractViewModel {
     }
 }
 
-interface IRunToCompare {
-    historyIndex: number,
-    startTime: number
-}

report-ng/app/src/value-converters/class-name-value-converter.ts

@@ -28,13 +28,13 @@ export class ClassNameValueConverter {
         switch (mode) {
             case ClassName.package:
                 if (value.lastIndexOf('.') > 0) {
-                    return value.substr(0, value.lastIndexOf('.'));
+                    return value.substring(0, value.lastIndexOf('.'));
                 } else {
                     return '';
                 }
             case ClassName.simpleName:
                 if (value.lastIndexOf('.') > 0) {
-                    return value.substr(value.lastIndexOf('.') + 1);
+                    return value.substring(value.lastIndexOf('.') + 1);
                 }
             case ClassName.full:
                 return value;