Skip to content

Commit 1218d2c

Browse files
Merge pull request #445 from telekom/feature/split-execution-file
Feature/ Split execution file to reduce initial load
2 parents 2a5532d + df740ad commit 1218d2c

File tree

33 files changed

+2079
-533
lines changed

33 files changed

+2079
-533
lines changed

core/src/main/java/eu/tsystems/mms/tic/testframework/report/model/context/LogMessage.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
*/
2121
package eu.tsystems.mms.tic.testframework.report.model.context;
2222

23+
import eu.tsystems.mms.tic.testframework.common.Testerra;
24+
import eu.tsystems.mms.tic.testframework.internal.IdGenerator;
2325
import eu.tsystems.mms.tic.testframework.logging.Loggable;
2426
import eu.tsystems.mms.tic.testframework.logging.Prompt;
2527
import java.util.Arrays;
@@ -42,6 +44,7 @@ public class LogMessage implements Serializable, Loggable {
4244
private final String message;
4345
private final Level level;
4446
private final boolean prompt;
47+
private String id;
4548

4649
/**
4750
* Creates a log message based on a Log4J log event
@@ -88,4 +91,11 @@ public Optional<Throwable> getThrown() {
8891
public boolean isPrompt() {
8992
return prompt;
9093
}
94+
95+
public String getId() {
96+
if (this.id == null) {
97+
this.id = Testerra.getInjector().getInstance(IdGenerator.class).generate().toString();
98+
}
99+
return this.id;
100+
}
91101
}

report-model/src/main/java/eu/tsystems/mms/tic/testframework/adapters/ContextExporter.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -299,9 +299,8 @@ public TestStepAction.Builder buildTestStepAction(eu.tsystems.mms.tic.testframew
299299
Optional<File.Builder> optional = Optional.ofNullable(builders[0]);
300300
optional.ifPresent(file -> entryBuilder.setScreenshotId(file.getId()));
301301
} else if (entry instanceof eu.tsystems.mms.tic.testframework.report.model.context.LogMessage) {
302-
eu.tsystems.mms.tic.testframework.report.model.context.LogMessage logEvent = (eu.tsystems.mms.tic.testframework.report.model.context.LogMessage) entry;
303-
Optional<LogMessage.Builder> optional = Optional.ofNullable(buildLogMessage(logEvent));
304-
optional.ifPresent(entryBuilder::setLogMessage);
302+
String logMessageId = ((eu.tsystems.mms.tic.testframework.report.model.context.LogMessage) entry).getId();
303+
entryBuilder.setLogMessageId(logMessageId);
305304
} else if (entry instanceof eu.tsystems.mms.tic.testframework.report.model.context.ErrorContext) {
306305
eu.tsystems.mms.tic.testframework.report.model.context.ErrorContext errorContext = (eu.tsystems.mms.tic.testframework.report.model.context.ErrorContext) entry;
307306
Optional<ErrorContext.Builder> optional = Optional.ofNullable(buildErrorContext(errorContext));
@@ -310,7 +309,7 @@ public TestStepAction.Builder buildTestStepAction(eu.tsystems.mms.tic.testframew
310309

311310
if (
312311
entryBuilder.hasErrorContext()
313-
|| entryBuilder.hasLogMessage()
312+
|| StringUtils.isNotBlank(entryBuilder.getLogMessageId())
314313
|| entryBuilder.hasClickPathEvent()
315314
|| StringUtils.isNotBlank(entryBuilder.getScreenshotId())
316315
) {
@@ -435,6 +434,7 @@ public LogMessage.Builder buildLogMessage(eu.tsystems.mms.tic.testframework.repo
435434
builder.setTimestamp(logMessage.getTimestamp());
436435
builder.setThreadName(logMessage.getThreadName());
437436
builder.setPrompt(logMessage.isPrompt());
437+
builder.setId(logMessage.getId());
438438

439439
logMessage.getThrown().ifPresent(t -> {
440440
traceThrowable(t, throwable -> {
@@ -478,10 +478,7 @@ public ExecutionContext.Builder buildExecutionContext(eu.tsystems.mms.tic.testfr
478478
map(executionContext.getRunConfig(), this::buildRunConfig, builder::setRunConfig);
479479
executionContext.readExclusiveSessionContexts().forEach(sessionContext -> builder.addExclusiveSessionContextIds(sessionContext.getId()));
480480
apply(executionContext.getEstimatedTestMethodCount(), builder::setEstimatedTestsCount);
481-
executionContext.readMethodContextLessLogs().forEach(logEvent -> {
482-
Optional<LogMessage.Builder> optional = Optional.ofNullable(buildLogMessage(logEvent));
483-
optional.ifPresent(builder::addLogMessages);
484-
});
481+
executionContext.readMethodContextLessLogs().forEach(logMessage -> builder.addLogMessageIds(logMessage.getId()));
485482
builder.putFailureCorridorLimits(FailureCorridorValue.FCV_HIGH_VALUE, FailureCorridor.getAllowedTestFailuresHIGH());
486483
builder.putFailureCorridorLimits(FailureCorridorValue.FCV_MID_VALUE, FailureCorridor.getAllowedTestFailuresMID());
487484
builder.putFailureCorridorLimits(FailureCorridorValue.FCV_LOW_VALUE, FailureCorridor.getAllowedTestFailuresLOW());

0 commit comments

Comments
 (0)