Skip to content

Commit 42e94ee

Browse files
Merge pull request #488 from telekom/fix/cucumber-testmethod-name
Fix scenario name of cucumber tests
2 parents 9675824 + a062cf2 commit 42e94ee

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

report-ng/app/src/components/threads/threads.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,8 @@ import {NavigationInstruction, RouteConfig, Router} from "aurelia-router";
3030
import * as echarts from "echarts";
3131
import {EChartsOption} from "echarts";
3232
import {data} from "../../services/report-model";
33-
import {
34-
IntlDateFormatValueConverter
35-
} from "t-systems-aurelia-components/src/value-converters/intl-date-format-value-converter";
36-
import {
37-
DurationFormatValueConverter
38-
} from "t-systems-aurelia-components/src/value-converters/duration-format-value-converter";
33+
import {IntlDateFormatValueConverter} from "t-systems-aurelia-components/src/value-converters/intl-date-format-value-converter";
34+
import {DurationFormatValueConverter} from "t-systems-aurelia-components/src/value-converters/duration-format-value-converter";
3935
import {ClassName, ClassNameValueConverter} from "../../value-converters/class-name-value-converter";
4036
import {MdcSelect} from "@aurelia-mdc-web/select";
4137
import MethodContext = data.MethodContext;
@@ -288,12 +284,16 @@ export class Threads extends AbstractViewModel {
288284
startTimes.push(methodContext.contextValues.startTime);
289285
});
290286

287+
291288
const chartStartTime = Math.min.apply(Math, startTimes) - this._gapFromBorderToStart;
292289
const statusConverter = this._statusConverter;
290+
const statisticsGenerator = this._statisticsGenerator;
291+
console.log("thread", threadCategories);
293292

294-
threadCategories.forEach(function (methodContexts, threadName) {
295-
methodContexts.forEach((context: MethodContext) => {
293+
threadCategories.forEach(function (methodContexts: MethodContext[], threadName: string) {
294+
methodContexts.forEach(async (context: MethodContext) => {
296295

296+
const methodDetails = await statisticsGenerator.getMethodDetails(context.contextValues.id);
297297
const itemColor = statusConverter.getColorForStatus(context.resultStatus);
298298
const duration = context.contextValues.endTime - context.contextValues.startTime;
299299
const classId = executionStatistics.classStatistics.find(classStat => {
@@ -302,9 +302,11 @@ export class Threads extends AbstractViewModel {
302302
.filter((value, index, self) => self.indexOf(value) === index);
303303
return classContextIds.includes(context.classContextId);
304304
}).classIdentifier;
305+
console.log("details", methodDetails.identifier);
306+
305307

306308
data.push({
307-
name: context.contextValues.name,
309+
name: methodDetails.identifier,
308310
value: [
309311
threadName,
310312
context.contextValues.startTime,

report-ng/app/src/components/timings/session-timings/session-timings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export class SessionTimings extends AbstractViewModel {
224224
formatter: function (params) {
225225
if (params.data) {
226226
const seriesIndex = (params.seriesIndex - 2); // two series as offset for the legend placeholder
227-
const testNames = this._dots[seriesIndex].information.methodList.map(method => method.methodContext.contextValues.name);
227+
const testNames = this._dots[seriesIndex].information.methodList.map(method => method.identifier);
228228
let tooltipString = '<div class="header" style="background-color: ' +
229229
params.color + ';"> ' + this._dots[seriesIndex].information.browserName + ', Version: ' +
230230
this._dots[seriesIndex].information.browserVersion + '</div> <br>';

report-ng/app/src/components/timings/test-timings/test-timings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export class TestTimings extends AbstractViewModel {
145145
this._methodDetails.forEach(method => {
146146
const testDurationMethod: ITestDurationMethod = {
147147
id: method.methodContext.contextValues.id,
148-
name: method.methodContext.contextValues.name,
148+
name: method.identifier,
149149
duration: (method.methodContext.contextValues.endTime - method.methodContext.contextValues.startTime)/1000,
150150
methodType: method.methodContext.methodType,
151151
status: method.methodContext.resultStatus

0 commit comments

Comments
 (0)