Merge pull request #85 from telekom/feature/transitive-dependency-update

Removed some transitive dependencies

Author: martingrossmann

core-interop/build.gradle

@@ -2,14 +2,15 @@ dependencies {
 
     api('org.testng:testng:7.4.0')
     //  {
-    // Update TestNG 7.4.0: This is not needed anymore because TestNG extremly reduced transitive dependencies.
+    // Update TestNG 7.4.0: This is not needed anymore because TestNG extremely reduced transitive dependencies.
     //
     // We have to exclude this here, because testng is using 25.1-android in dependency com.google.inject:guice:4.1.0
     // This will lead to a version clash with selenium and this will produce ImmutableMapErrors on WebDriverManager.getWebDriver
     //        exclude group: 'com.google.guava', module: 'guava'
     //    }
 
     api 'commons-io:commons-io:2.6'
+    // StringUtils needs api dep
     api 'org.apache.commons:commons-lang3:3.9'
 
     // <TesterraLogger>

core-interop/src/main/java/eu/tsystems/mms/tic/testframework/utils/StringUtils.java

@@ -29,7 +29,10 @@
 
 /**
  * Sammlung von StringUtils.
+ *
+ * @deprecated This class is mainly used for Legacy Report. Please use {@link org.apache.commons.lang3.StringUtils} instead.
  */
+@Deprecated
 public final class StringUtils extends org.apache.commons.lang3.StringUtils {
 
     /**

core/build.gradle

@@ -9,7 +9,7 @@ dependencies {
     // </PdfUtils>
 
     // <RESTUtils>
-    api 'com.sun.jersey:jersey-client:1.19.3'
+    implementation 'com.sun.jersey:jersey-client:1.19.3'
     // </RESTUtils
 
     api "com.google.guava:guava:${guavaVersion}"

driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/utils/UITestUtils.java

@@ -28,15 +28,24 @@
 import eu.tsystems.mms.tic.testframework.internal.Constants;
 import eu.tsystems.mms.tic.testframework.internal.Flags;
 import eu.tsystems.mms.tic.testframework.internal.Viewport;
+import eu.tsystems.mms.tic.testframework.report.Report;
 import eu.tsystems.mms.tic.testframework.report.TesterraListener;
 import eu.tsystems.mms.tic.testframework.report.model.context.MethodContext;
 import eu.tsystems.mms.tic.testframework.report.model.context.Screenshot;
-import eu.tsystems.mms.tic.testframework.report.Report;
 import eu.tsystems.mms.tic.testframework.report.model.context.SessionContext;
 import eu.tsystems.mms.tic.testframework.report.utils.ExecutionContextController;
-import eu.tsystems.mms.tic.testframework.webdrivermanager.AbstractWebDriverConfiguration;
 import eu.tsystems.mms.tic.testframework.webdrivermanager.WebDriverRequest;
 import eu.tsystems.mms.tic.testframework.webdrivermanager.WebDriverSessionsManager;
+import org.openqa.selenium.OutputType;
+import org.openqa.selenium.TakesScreenshot;
+import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.support.events.EventFiringWebDriver;
+import org.sikuli.api.ScreenLocation;
+import org.sikuli.api.ScreenRegion;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.imageio.ImageIO;
 import java.awt.image.BufferedImage;
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -53,15 +62,6 @@
 import java.util.Properties;
 import java.util.Set;
 import java.util.stream.Stream;
-import javax.imageio.ImageIO;
-import org.openqa.selenium.OutputType;
-import org.openqa.selenium.TakesScreenshot;
-import org.openqa.selenium.WebDriver;
-import org.openqa.selenium.support.events.EventFiringWebDriver;
-import org.sikuli.api.ScreenLocation;
-import org.sikuli.api.ScreenRegion;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Helper class containing some util methods for tt.
@@ -223,7 +223,7 @@ private static void makeSimpleScreenshot(WebDriver driver, File screenShotTarget
     /**
      * Utility to store a Screenshot at the specified location.
      *
-     * @param image      BufferedImage
+     * @param image BufferedImage
      * @param targetFile filePath with fileName
      */
     private static void saveBufferedImage(BufferedImage image, File targetFile) {
@@ -240,7 +240,7 @@ private static void saveBufferedImage(BufferedImage image, File targetFile) {
     /**
      * Save page source to file.
      *
-     * @param pageSource       page source.
+     * @param pageSource page source.
      * @param sourceTargetFile target file.
      */
     private static void savePageSource(final String pageSource, final File sourceTargetFile) {

image-processing/build.gradle

@@ -8,7 +8,7 @@ def opencv = [
 ]
 
 dependencies {
-    api core
+    implementation core
     implementation opencv
 
     // <core>

report-model/build.gradle

@@ -11,8 +11,8 @@ apply plugin: 'com.google.protobuf'
 def protobufVersion = '3.14.0'
 
 dependencies {
-    api core
-    api "com.google.protobuf:protobuf-java:$protobufVersion"
+    implementation core
+    implementation "com.google.protobuf:protobuf-java:$protobufVersion"
     // <GenerateReportModelListener>
     implementation group: 'com.google.code.gson', name: 'gson', version: '2.8.6'
     // <GenerateReportModelListener>

report-ng/build.gradle

@@ -2,8 +2,12 @@ plugins {
     id 'java'
 }
 
+def protobufVersion = '3.14.0'
+
 dependencies {
+    implementation core
     implementation project(':report-model')
+    implementation "com.google.protobuf:protobuf-java:$protobufVersion"
 }
 
 task destClean {