Skip to content

Commit 717db70

Browse files
authored
Merge pull request #4014 from tredmon/pullsecrets-schema
fix: schema for agent.image.pullSecrets
2 parents 8eeba46 + af9e89e commit 717db70

File tree

6 files changed

+23
-1
lines changed

6 files changed

+23
-1
lines changed

CHANGELOG.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ items:
8383
- connector-foreground => userd
8484
- daemon-foreground => rootd
8585
- kubeauth-foreground => kubeauthd
86+
- type: bugfix
87+
title: Fix schema for agent.image.pullSecrets
88+
body: >-
89+
The `agent.image.pullSecrets` is referenced by the helm chart's deployment.yaml but was previously disallowed by the schema file.
8690
- version: 2.25.1
8791
date: 2025-11-10
8892
notes:

charts/telepresence-oss/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ The following tables lists the configurable parameters of the Telepresence chart
2525
| affinity | Define the `Node` Affinity and Anti-Affinity for the Traffic Manager. | `{}` |
2626
| agent.image.name | The name of the injected agent image | `""` |
2727
| agent.image.pullPolicy | Pull policy in the webhook for the traffic agent image | `IfNotPresent` |
28+
| agent.image.pullSecrets | The `Secret` storing any credentials needed to access the image in a private registry. | |
2829
| agent.image.tag | The tag for the injected agent image | `""` (Defined in `appVersion` Chart.yaml) |
2930
| agent.image.registry | The registry for the injected agent image | `ghcr.io/telepresenceio` |
3031
| agent.initResources | The resources for the injected init container | |

charts/telepresence-oss/values.schema.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ properties:
4343
pullPolicy:
4444
description: Pull policy in the webhook for the traffic agent image
4545
$ref: "#/$defs/pullPolicy"
46+
pullSecrets:
47+
description: The Secret storing any credentials needed to access the image in a private registry
48+
type: array
49+
items:
50+
$ref: "#/$defs/localObjectReference"
4651
registry:
4752
description: The registry for the injected agent image
4853
type: string

docs/helm/values.schema.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/release-notes.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ The daemons are therefore now renamed:
5757
- kubeauth-foreground => kubeauthd
5858
</div>
5959

60+
## <div style="display:flex;"><img src="images/bugfix.png" alt="bugfix" style="width:30px;height:fit-content;"/><div style="display:flex;margin-left:7px;">Fix schema for agent.image.pullSecrets</div></div>
61+
<div style="margin-left: 15px">
62+
63+
The `agent.image.pullSecrets` is referenced by the helm chart's deployment.yaml but was previously disallowed by the schema file.
64+
</div>
65+
6066
## Version 2.25.1 <span style="font-size: 16px;">(November 10)</span>
6167
## <div style="display:flex;"><img src="images/bugfix.png" alt="bugfix" style="width:30px;height:fit-content;"/><div style="display:flex;margin-left:7px;">Volumes did not mount correctly when using `telepresence connect --docker` when Docker had IPv6 enabled.</div></div>
6268
<div style="margin-left: 15px">

docs/release-notes.mdx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ The daemons are therefore now renamed:
6363
- kubeauth-foreground => kubeauthd
6464
</Body>
6565
</Note>
66+
<Note>
67+
<Title type="bugfix">Fix schema for agent.image.pullSecrets</Title>
68+
<Body>
69+
The `agent.image.pullSecrets` is referenced by the helm chart's deployment.yaml but was previously disallowed by the schema file.
70+
</Body>
71+
</Note>
6672
## Version 2.25.1 <span style={{fontSize:'16px'}}>(November 10)</span>
6773
<Note>
6874
<Title type="bugfix">Volumes did not mount correctly when using `telepresence connect --docker` when Docker had IPv6 enabled.</Title>

0 commit comments

Comments
 (0)