Skip to content

Commit eb1a320

Browse files
austpaulKristian
authored andcommitted
Add support for specific container name (#17)
* Added service name output. Introduced new optional input to specify container name explicitly, * Added support for overriding container name in task definition * Setting name_prefix as task id * Removed task definition id * Formatting * Fixed typo * Added variables for overriding container name * Reintroduced container name support without explicit flag.
1 parent f9d7236 commit eb1a320

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ resource "aws_ecs_task_definition" "task" {
111111

112112
container_definitions = <<EOF
113113
[{
114-
"name": "${var.name_prefix}",
114+
"name": "${var.container_name != "" ? var.container_name : var.name_prefix}",
115115
"image": "${var.task_container_image}",
116116
${local.repository_credentials_rendered}
117117
"essential": true,
@@ -154,7 +154,7 @@ resource "aws_ecs_service" "service" {
154154
}
155155

156156
load_balancer {
157-
container_name = "${var.name_prefix}"
157+
container_name = "${var.container_name != "" ? var.container_name : var.name_prefix}"
158158
container_port = "${var.task_container_port}"
159159
target_group_arn = "${aws_lb_target_group.task.arn}"
160160
}

variables.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ variable "name_prefix" {
55
description = "A prefix used for naming resources."
66
}
77

8+
variable "container_name" {
9+
description = "Optional name for the container to be used instead of name_prefix. Useful when when constructing an imagedefinitons.json file for continuous deployment using Codepipeline."
10+
default = ""
11+
}
12+
813
variable "vpc_id" {
914
description = "The VPC ID."
1015
}

0 commit comments

Comments
 (0)